Closed
Bug 1446925
Opened 7 years ago
Closed 7 years ago
Remove useless references to instantbird
Categories
(Toolkit :: Application Update, enhancement)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: sreeise, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=JavaScript])
Attachments
(1 file)
|
1.40 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
|
Reporter | |
Updated•7 years ago
|
Component: General → Application Update
Product: Core → Toolkit
|
Assignee | |
Comment 2•7 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #0)
> https://searchfox.org/mozilla-central/rev/
> 3abf6fa7e2a6d9a7bfb88796141b0f012e68c2db/toolkit/mozapps/update/
> nsUpdateService.js#1627
> https://searchfox.org/mozilla-central/rev/
> 3abf6fa7e2a6d9a7bfb88796141b0f012e68c2db/toolkit/mozapps/update/
> nsUpdateService.js#188-189
Hey Sylvestre,
I can look at this if you don't mind. It would technically be my second bug if its ok. Just so I am sure, the switch case line for xul-windows-visible in nsUpdateService.js as well as the reference to instantbird where the maps app ids are just need to be removed?
Flags: needinfo?(sledru)
|
|
Reporter | |
Comment 3•7 years ago
|
||
It is ok :) Good first bug is just an expression which means "new comers".
Your assumption is correct!
Flags: needinfo?(sledru)
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #3)
> It is ok :) Good first bug is just an expression which means "new comers".
> Your assumption is correct!
Awesome. Do you mind assigning me to the bug? I will gladly submit a patch.
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → reeisesean
|
|
Assignee | |
Comment 5•7 years ago
|
||
The patch removes the two references. I am unsure how to get the white space out of the middle without actually altering the patch file itself. I will keep working on it to see if I can get a patch without that white space.
Flags: needinfo?(sledru)
|
|
Reporter | |
Comment 6•7 years ago
|
||
Looks good. You should now look for a reviewer (florian maybe?)
Flags: needinfo?(sledru)
|
||
Updated•7 years ago
|
Attachment #8960727 -
Flags: review+
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [good first bug][lang=JavaScript] → [good first bug][lang=JavaScript][checkin-needed]
|
|
Assignee | |
Updated•7 years ago
|
Keywords: good-first-bug → checkin-needed
Whiteboard: [good first bug][lang=JavaScript][checkin-needed] → [good first bug][lang=JavaScript]
|
|
Assignee | |
Comment 7•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Keywords: good-first-bug
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4203bc958351
Removed unused instantbird references from nsUpdateService.js r=rstrong
Keywords: checkin-needed
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
|
Reporter | |
Comment 10•7 years ago
|
||
Sean, bravo! :)
You need to log in
before you can comment on or make changes to this bug.
Description
•