1446933 - Remove 'using namespace mozilla::net' from BackgroundUtils.h

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P3)

Description

[Christoph Kerschbaumer [:ckerschb]]

That sort of namespace usage is not ok within headers, we should fix that.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: namespace.patch

Comment 2

[Andrea Marchesini [:baku]]

Attachment: namespace.patch

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8981938 [details] [diff] [review]
namespace.patch

Review of attachment 8981938 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/data/nsDataHandler.cpp
@@ +86,5 @@
>                  return NS_ERROR_OUT_OF_MEMORY;
>              }
>          }
>  
> +        rv = NS_MutateURI(new net::nsSimpleURI::Mutator())

Why is this just net:: instead of mozilla::net, as it is elsewhere in the file? 

This applies here, and pretty much everywhere else where it's net:: instead of mozilla::net:, though I think this is the only file that actually has a mozilla::net reference elsewhere in the file.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb54a3e980ae
Remove 'using namespace mozilla::net' from BackgroundUtils.h, r=qdot

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/eb54a3e980ae