Closed
Bug 1446933
Opened 4 years ago
Closed 4 years ago
Remove 'using namespace mozilla::net' from BackgroundUtils.h
Categories
(Core :: DOM: Security, enhancement, P3)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: ckerschb, Assigned: baku)
References
Details
(Whiteboard: [domsecurity-backlog1])
Attachments
(1 file, 1 obsolete file)
19.85 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
That sort of namespace usage is not ok within headers, we should fix that.
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8981895 -
Flags: review?(kyle)
Assignee | ||
Comment 2•4 years ago
|
||
Attachment #8981895 -
Attachment is obsolete: true
Attachment #8981895 -
Flags: review?(kyle)
Attachment #8981938 -
Flags: review?(kyle)
Comment 3•4 years ago
|
||
Comment on attachment 8981938 [details] [diff] [review] namespace.patch Review of attachment 8981938 [details] [diff] [review]: ----------------------------------------------------------------- ::: netwerk/protocol/data/nsDataHandler.cpp @@ +86,5 @@ > return NS_ERROR_OUT_OF_MEMORY; > } > } > > + rv = NS_MutateURI(new net::nsSimpleURI::Mutator()) Why is this just net:: instead of mozilla::net, as it is elsewhere in the file? This applies here, and pretty much everywhere else where it's net:: instead of mozilla::net:, though I think this is the only file that actually has a mozilla::net reference elsewhere in the file.
Attachment #8981938 -
Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb54a3e980ae Remove 'using namespace mozilla::net' from BackgroundUtils.h, r=qdot
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb54a3e980ae
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•