Closed Bug 1446933 Opened 3 years ago Closed 3 years ago

Remove 'using namespace mozilla::net' from BackgroundUtils.h

Categories

(Core :: DOM: Security, enhancement, P3)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: ckerschb, Assigned: baku)

References

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 file, 1 obsolete file)

namespace.patch
19.85 KB, patch
qdot
: review+
Details | Diff | Splinter Review 
That sort of namespace usage is not ok within headers, we should fix that.
Depends on: 1439713
Priority: -- → P3
Whiteboard: [domsecurity-backlog1]
Attached patch namespace.patch (obsolete) — — Splinter Review
Assignee: nobody → amarchesini
Attachment #8981895 - Flags: review?(kyle)
Attached patch namespace.patch — — Splinter Review
Attachment #8981895 - Attachment is obsolete: true
Attachment #8981895 - Flags: review?(kyle)
Attachment #8981938 - Flags: review?(kyle)
Comment on attachment 8981938 [details] [diff] [review]
namespace.patch

Review of attachment 8981938 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/data/nsDataHandler.cpp
@@ +86,5 @@
>                  return NS_ERROR_OUT_OF_MEMORY;
>              }
>          }
>  
> +        rv = NS_MutateURI(new net::nsSimpleURI::Mutator())

Why is this just net:: instead of mozilla::net, as it is elsewhere in the file? 

This applies here, and pretty much everywhere else where it's net:: instead of mozilla::net:, though I think this is the only file that actually has a mozilla::net reference elsewhere in the file.
Attachment #8981938 - Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb54a3e980ae
Remove 'using namespace mozilla::net' from BackgroundUtils.h, r=qdot
https://hg.mozilla.org/mozilla-central/rev/eb54a3e980ae
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.