Closed
Bug 144700
Opened 23 years ago
Closed 23 years ago
To polish the nsIAccessibleHyperLink interface
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: gilbert.fang, Assigned: gilbert.fang)
References
Details
Attachments
(1 file, 1 obsolete file)
|
770 bytes,
patch
|
yuanyi21
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
In the mozilla/ accessible/ public/ nsIAccessibleHyperLink.idl ,
1, At line 34, readonly attribute long links; I think this from the orignal
"long getNAnchors ();", which means the number of anchors in this link.
So, it is better that the attribute's name is *anchors*.
2, For line 35 and 36, it is better to remove the first word "get" of the
attribute name, so that they sound like a attribute instead of a method.
| Assignee | ||
Comment 1•23 years ago
|
||
Hi , Bill and John
Would you please spend some time to investigate this? And because it is the
interface definition and most of my work will base on this, I am very eager to
know your opinion on it.
Summary: To polish the nsIAccessibleHyperLink interface → To polish the nsIAccessibleHyperLink interface
| Assignee | ||
Comment 2•23 years ago
|
||
need r=?
| Assignee | ||
Comment 3•23 years ago
|
||
Kyle suggested that the initial letter of attribute should be lowercase.
Attachment #83864 -
Attachment is obsolete: true
Comment on attachment 84009 [details] [diff] [review]
recreate the patch per kyle's suggestion
r=kyle.yuan
Attachment #84009 -
Flags: review+
| Assignee | ||
Comment 5•23 years ago
|
||
see also bugsceri 75
Comment 6•23 years ago
|
||
Comment on attachment 84009 [details] [diff] [review]
recreate the patch per kyle's suggestion
sr=jst as long as aaronl or jgaunt ok this change.
Attachment #84009 -
Flags: superreview+
Comment 7•23 years ago
|
||
r=aaronl
| Assignee | ||
Comment 8•23 years ago
|
||
thanks to aaronl and jst.
| Assignee | ||
Comment 9•23 years ago
|
||
Kyle has checked in the patch
http://bugzilla.mozilla.org/attachment.cgi?id=84009&action=view
Thanks.
Comment 11•23 years ago
|
||
-- Checked nsIAccessibleHyperLink.idl in latest Mozilla trunk build. Required
changed are made. Marking the bug as verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•