Use waitForNewTab instead of progress listener in addJsonViewTab

RESOLVED FIXED in Firefox 61

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

unspecified
Firefox 61

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

addJsonViewTab uses a progress listener which is a bit ugly. BrowserTestUtils.waitForNewTab does basically the same thing but the code becomes clearer.
Posted image server-error.png
@Oriol, can you please update the patch I can't publish it from some reason. I am seeing HTTP 500 INTERNAL SERVER ERROR any time I press the review "Publish" button.

Otherwise, the patch looks good.

Honza
Attachment #8960183 - Attachment is obsolete: true
Attachment #8960183 - Flags: review?(odvarko)
I also thought it was strange that two mozreview-request comments appeared, and in rb the title of the patch was not shown.
Comment on attachment 8960226 [details]
Bug 1447012 - Use waitForNewTab instead of progress listener in addJsonViewTab

https://reviewboard.mozilla.org/r/228988/#review234706

Thanks for the patch!
R+ assuming try is green
Honza
Attachment #8960226 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41097954197f
Use waitForNewTab instead of progress listener in addJsonViewTab r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/41097954197f
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.