1447045 - Maximisation delta of 8 px not enough on certain Linux configs

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

test_window_maximize.py [1] uses a delta of 8 px on non-Windows
platforms when checking whether the window was maximised:

    (max width - delta) = acceptable max width

This is done so that window manager specific limitations do not
affect the outcome of the tests.  On my current Linux setup where I
X11 forward the Firefox window to macOS a delta of 8 px is not enough.
The minimum requirement is 22px.

  [1] https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py#37

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1447045 - Increase maximize delta to 22 px.

Linux window managers and desktop environments can cause the available
surface area of the screen to be shrunk due to UI elements such as
menus.  Window managers can also add additional window decorations
that are outside the control of Firefox.

When X11 forwarding a Firefox window to macOS the XQuartz window
decoration adds 22 px.  This patch increases the delta from 8 px.

Review commit: https://reviewboard.mozilla.org/r/228984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228984/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8960224 [details]
Bug 1447045 - Increase maximize delta to 22 px.

https://reviewboard.mozilla.org/r/228984/#review235090

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ac3210cae51
Increase maximize delta to 22 px. r=maja_zf

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4ac3210cae51