Closed
Bug 1447051
Opened 6 years ago
Closed 6 years ago
about:preferences shows "Preview on Nightly" when 'Disable built-in PDF viewer' policy is active
Categories
(Firefox :: Enterprise Policies, defect)
Tracking
()
VERIFIED
FIXED
Firefox 61
People
(Reporter: Abe_LV, Assigned: bytesized)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
bdahl
:
review+
Felipe
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
Steps to reproduce: screen capture- https://testing-1.tinytake.com/sf/MjQ1MDAwNF83NDAxNjIw 1- Use "DisableBuiltinPDFViewer": true policy 2- Go to about:preferences ->Applications 3- observe the action for the PDF content type Actual result: "Preview in Nightly" option is still available Expected Result: "Preview in Nightly" option should be hidden Note- a previously opened pdf tab becomes a blank page when the policy is set to active.
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(ksteuber)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ksteuber
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(ksteuber)
Assignee | ||
Updated•6 years ago
|
Attachment #8960283 -
Flags: review?(felipc)
Attachment #8960283 -
Flags: review?(bdahl)
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8960283 [details] Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active https://reviewboard.mozilla.org/r/229048/#review234814
Attachment #8960283 -
Flags: review?(felipc) → review+
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8960283 [details] Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active https://reviewboard.mozilla.org/r/229048/#review234876
Attachment #8960283 -
Flags: review?(bdahl) → review+
Pushed by ksteuber@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3226b1ae25d6 about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active r=bdahl,Felipe
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3226b1ae25d6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8960283 [details] Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active Approval Request Comment [Feature/Bug causing the regression]: Enterprise Policy Engine [User impact if declined]: about:preferences will indicate that PDFs will be previewed within Firefox even if that feature is disabled by policy. [Is this code covered by automated tests?]: The policy has tests to ensure that it is functioning properly. There is not a test to ensure that this particular UI element displays properly. [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Abe will be verifying this fix. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Patch only affects whether the PDF handler is enabled in the UI and change has no effect if the policy engine is inactive or if the DisableBuiltinPDFViewer policy is inactive. [String changes made/needed]: None
Attachment #8960283 -
Flags: approval-mozilla-beta?
Comment 7•6 years ago
|
||
Comment on attachment 8960283 [details] Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active enterprise policy fix for beta60
Attachment #8960283 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/013a1953f0fc
status-firefox60:
--- → fixed
Reporter | ||
Comment 9•6 years ago
|
||
We tested this and it is now verified as fixed. about:preferences does not show 'Preview in Nightly' with this policy.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 10•6 years ago
|
||
We also tested this on beta builds and it is verified as fixed. Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760
You need to log in
before you can comment on or make changes to this bug.
Description
•