1447051 - about:preferences shows "Preview on Nightly" when 'Disable built-in PDF viewer' policy is active

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Abe - QA (:Abe_LV)]

Steps to reproduce:
screen capture- https://testing-1.tinytake.com/sf/MjQ1MDAwNF83NDAxNjIw

1- Use  "DisableBuiltinPDFViewer": true policy
2- Go to about:preferences ->Applications
3- observe the action for the PDF content type

Actual result:
"Preview in Nightly" option is still available

Expected Result:

"Preview in Nightly" option should be hidden

Note- a previously opened pdf tab becomes a blank page when the policy is set to active.

Comment 1

[Robin Steuber (she/her) [:bytesized] (Out until April 4)]

Attachment: Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active

Review commit: https://reviewboard.mozilla.org/r/229048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229048/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8960283 [details]
Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active

https://reviewboard.mozilla.org/r/229048/#review234814

Comment 3

[Brendan Dahl [:bdahl]]

Comment on attachment 8960283 [details]
Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active

https://reviewboard.mozilla.org/r/229048/#review234876

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3226b1ae25d6
about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active r=bdahl,Felipe

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3226b1ae25d6

Comment 6

[Robin Steuber (she/her) [:bytesized] (Out until April 4)]

Comment on attachment 8960283 [details]
Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise Policy Engine
[User impact if declined]: about:preferences will indicate that PDFs will be previewed within Firefox even if that feature is disabled by policy.
[Is this code covered by automated tests?]: The policy has tests to ensure that it is functioning properly. There is not a test to ensure that this particular UI element displays properly.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Abe will be verifying this fix.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Patch only affects whether the PDF handler is enabled in the UI and change has no effect if the policy engine is inactive or if the DisableBuiltinPDFViewer policy is inactive.
[String changes made/needed]: None

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8960283 [details]
Bug 1447051 - about:preferences should not offer to Preview PDFs when the DisableBuiltinPDFViewer policy is active

enterprise policy fix for beta60

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/013a1953f0fc

Comment 9

[Abe - QA (:Abe_LV)]

We tested this and it is now verified as fixed. about:preferences does not show 'Preview in Nightly' with this policy.

Comment 10

[Abe - QA (:Abe_LV)]

We also tested this on beta builds and it is verified as fixed.
Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760