Closed Bug 1447095 Opened 6 years ago Closed 6 years ago

[FTL] Initialize access key candidates coming from value

Categories

(Webtools Graveyard :: Pontoon, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mathjazz, Assigned: mathjazz)

Details

Attachments

(1 file)

In bug 1445435 we extended support for access key generators beyond the attributes textarea elements.

However, we forgot to update the even trigger that initializes the list of candidates when the translated string is loaded in the translation editor.

To reproduce, open the following string and notice how the list of access key candidates doesn't render:
https://pontoon.mozilla.org/sl/firefox/browser/browser/preferences/preferences.ftl/?search=accessk&string=176239
Related: in bug 1445435 we also made access keys case sensitive but forgot to update the CSS rule that renders the access key in the input element as uppercase.
Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/5fb2cf9407508b8ec787e5aaa3b5e16dd5f08fb0
Bug 1447095: Initialize access keys generated from value (#906)

The list of candidates is now initialized properly:
by extending the selector.

Related fixes:
* The access key textarea element no longer transforms text to uppercase
* Properly update selected access key if entered directly into textarea
Fixed:
https://github.com/mozilla/pontoon/commit/5fb2cf9407508b8ec787e5aaa3b5e16dd5f08fb0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: