Closed Bug 1447189 Opened 6 years ago Closed 6 years ago

Permafailing tier2 busage ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskSkip TEST-UNEXPECTED-FAIL

Categories

(Testing :: XPCShell Harness, defect, P5)

Version 3
defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: zbraniecki)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=169059693&repo=mozilla-central

https://queue.taskcluster.net/v1/task/CR_L8p-5RkGsmHFf-CBE4Q/runs/0/artifacts/public/logs/live_backing.log

[task 2018-03-19T23:27:01.603Z] 23:27:01     INFO - /builds/worker/workspace/build/src/testing/xpcshell/selftest.py
[task 2018-03-19T23:27:01.603Z] 23:27:01     INFO - ============================= test session starts ==============================
[task 2018-03-19T23:27:01.604Z] 23:27:01     INFO - platform linux2 -- Python 2.7.9, pytest-3.1.3, py-1.4.34, pluggy-0.4.0 -- /builds/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python
[task 2018-03-19T23:27:01.605Z] 23:27:01     INFO - rootdir: /builds/worker/workspace/build/src, inifile:
[task 2018-03-19T23:27:01.605Z] 23:27:01     INFO - collecting ... collected 55 items
[task 2018-03-19T23:27:01.605Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskRunNextTest PASSED
[task 2018-03-19T23:27:01.605Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskSkip TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.606Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskSkipAll TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.606Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskStackTrace TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.606Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskTestFailureInside PASSED
[task 2018-03-19T23:27:01.606Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskTestMultiple TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.606Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskTestRejected PASSED
[task 2018-03-19T23:27:01.607Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskTestSingle TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.607Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTestFailing PASSED
[task 2018-03-19T23:27:01.607Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTestSimple TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.607Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTestUncaughtRejection PASSED
[task 2018-03-19T23:27:01.607Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTestUncaughtRejectionJSM PASSED
[task 2018-03-19T23:27:01.607Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAssertStack TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.607Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAsyncCleanup TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.607Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testChild TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.608Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testChildFail TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.608Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testChildHang TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.608Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testChildMozinfo TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.608Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testChildPass TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.608Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoPrintWhenVerboseExplicit TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.608Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoPrintWhenVerboseInManifest TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.608Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoPrintWhenVerboseNotExplicit TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.609Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoReportForeignObject TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.609Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoReportNonSyntaxError TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.609Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoReportRefError TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.609Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoReportSyntaxError TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.609Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoThrowForeignObject TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.609Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testDoThrowString TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.610Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testFail PASSED
[task 2018-03-19T23:27:01.610Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testHangingTimeout <- ../../../../../usr/lib/python2.7/unittest/case.py SKIPPED
[task 2018-03-19T23:27:01.610Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testKnownFail PASSED
[task 2018-03-19T23:27:01.610Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testLogCorrectFileName TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.610Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testMissingHeadFile PASSED
[task 2018-03-19T23:27:01.610Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testMozinfo TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.611Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNoRunTestAddTask TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.611Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNoRunTestAddTaskFail PASSED
[task 2018-03-19T23:27:01.611Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNoRunTestAddTaskMultiple TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.611Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNoRunTestAddTest TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.611Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNoRunTestAddTestAddTask TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.611Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNoRunTestAddTestFail PASSED
[task 2018-03-19T23:27:01.612Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNoRunTestEmptyTest TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.612Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNotSkipForAddTask TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.612Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testNotSkipForAddTest TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.612Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testPass TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.612Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testPassFail TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.612Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testRandomExecution TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.613Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testReturnNonzero PASSED
[task 2018-03-19T23:27:01.613Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testSkip PASSED
[task 2018-03-19T23:27:01.613Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testSkipForAddTask TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.613Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testSkipForAddTest TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.613Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testSyntaxError PASSED
[task 2018-03-19T23:27:01.613Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testUncaughtRejection TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.613Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testUncaughtRejectionJSM TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.613Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testUnexpectedPass TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.614Z] 23:27:01  WARNING - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testUnicodeInAssertMethods TEST-UNEXPECTED-FAIL
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO - =================================== FAILURES ===================================
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO - ______________________ XPCShellTestsTests.testAddTaskSkip ______________________
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO - self = <selftest.XPCShellTestsTests testMethod=testAddTaskSkip>
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO -     def testAddTaskSkip(self):
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO -         self.writeFile("test_tasks_skip.js", ADD_TASK_SKIP)
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO -         self.writeManifest(["test_tasks_skip.js"])
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO - >       self.assertTestResult(True)
[task 2018-03-19T23:27:01.614Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py:1068:
[task 2018-03-19T23:27:01.615Z] 23:27:01     INFO - _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2018-03-19T23:27:01.615Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py:527: in assertTestResult
[task 2018-03-19T23:27:01.615Z] 23:27:01     INFO -     """ % ("passed" if expected else "failed", self.log.getvalue()))
[task 2018-03-19T23:27:01.615Z] 23:27:01     INFO - E   AssertionError: Tests should have passed, log:
[task 2018-03-19T23:27:01.615Z] 23:27:01     INFO - E   ========
[task 2018-03-19T23:27:01.615Z] 23:27:01     INFO - E   MOZ_NODE_PATH environment variable not set. Tests requiring http/2 will fail.
[task 2018-03-19T23:27:01.615Z] 23:27:01     INFO - E   Running tests sequentially.
[task 2018-03-19T23:27:01.616Z] 23:27:01     INFO - E   SUITE-START | Running 1 tests
[task 2018-03-19T23:27:01.616Z] 23:27:01     INFO - E   TEST-START | test_tasks_skip.js
[task 2018-03-19T23:27:01.616Z] 23:27:01  WARNING - E   TEST-UNEXPECTED-FAIL | test_tasks_skip.js | xpcshell return code: -11
[task 2018-03-19T23:27:01.616Z] 23:27:01     INFO - E   TEST-INFO took 209ms
[task 2018-03-19T23:27:01.616Z] 23:27:01     INFO - E   >>>>>>>
[task 2018-03-19T23:27:01.616Z] 23:27:01     INFO - E   PID 6497 | [6497, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 508
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | Assertion failure: aDefaultLocale.IsEmpty() || Locale(aDefaultLocale).IsValid() (If specified, default locale must be a valid BCP47 language tag.), at /builds/worker/workspace/build/src/intl/locale/LocaleService.cpp:516
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #01: mozilla::intl::LocaleService::NegotiateLanguages [intl/locale/LocaleService.cpp:515]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #02: mozilla::intl::LocaleService::NegotiateAppLocales [xpcom/ds/nsTArray.h:2322]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #03: mozilla::intl::LocaleService::GetAppLocaleAsLangTag [intl/locale/LocaleService.cpp:750]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #04: nsChromeRegistryChrome::ChromePackageFromPackageEntry [chrome/nsChromeRegistryChrome.cpp:408]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #05: nsChromeRegistryChrome::ManifestLocale [chrome/nsChromeRegistryChrome.cpp:727]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #06: ParseManifest [xpcom/components/ManifestParser.cpp:734]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #07: DoRegisterManifest [xpcom/string/nsTSubstring.h:77]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #08: nsComponentManagerImpl::ManifestManifest [xpcom/components/nsComponentManager.cpp:565]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #09: ParseManifest [xpcom/components/ManifestParser.cpp:743]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #10: DoRegisterManifest [xpcom/string/nsTSubstring.h:77]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #11: nsComponentManagerImpl::RereadChromeManifests [xpcom/components/nsComponentManager.cpp:557]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #12: nsComponentManagerImpl::Init [xpcom/components/nsComponentManager.cpp:345]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #13: NS_InitXPCOM2 [xpcom/build/XPCOMInit.cpp:677]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #14: XRE_XPCShellMain [xpcom/base/nsCOMPtr.h:787]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #15: mozilla::BootstrapImpl::XRE_XPCShellMain [toolkit/xre/Bootstrap.cpp:57]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #16: main [js/xpconnect/shell/xpcshell.cpp:67]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #17: libc.so.6 + 0x1eead
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #18: _start
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   PID 6497 | ExceptionHandler::GenerateDump cloned child 6502
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   PID 6497 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   <<<<<<<
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   INFO | Result summary:
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   INFO | Passed: 0
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   INFO | Failed: 1
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   INFO | Todo: 0
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   INFO | Retried: 0
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E   SUITE-END | took 0s
[task 2018-03-19T23:27:01.620Z] 23:27:01     INFO - E
[task 2018-03-19T23:27:01.621Z] 23:27:01     INFO - E   ========
[task 2018-03-19T23:27:01.621Z] 23:27:01     INFO - ____________________ XPCShellTestsTests.testAddTaskSkipAll _____________________
[task 2018-03-19T23:27:01.621Z] 23:27:01     INFO - self = <selftest.XPCShellTestsTests testMethod=testAddTaskSkipAll>
[task 2018-03-19T23:27:01.621Z] 23:27:01     INFO -     def testAddTaskSkipAll(self):
[task 2018-03-19T23:27:01.621Z] 23:27:01     INFO -         self.writeFile("test_tasks_skipall.js", ADD_TASK_SKIPALL)
[task 2018-03-19T23:27:01.621Z] 23:27:01     INFO -         self.writeManifest(["test_tasks_skipall.js"])
[task 2018-03-19T23:27:01.621Z] 23:27:01     INFO - >       self.assertTestResult(True)
[task 2018-03-19T23:27:01.622Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py:1077:
[task 2018-03-19T23:27:01.622Z] 23:27:01     INFO - _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2018-03-19T23:27:01.622Z] 23:27:01     INFO - ../testing/xpcshell/selftest.py:527: in assertTestResult
[task 2018-03-19T23:27:01.622Z] 23:27:01     INFO -     """ % ("passed" if expected else "failed", self.log.getvalue()))
[task 2018-03-19T23:27:01.622Z] 23:27:01     INFO - E   AssertionError: Tests should have passed, log:
[task 2018-03-19T23:27:01.622Z] 23:27:01     INFO - E   ========
[task 2018-03-19T23:27:01.622Z] 23:27:01     INFO - E   MOZ_NODE_PATH environment variable not set. Tests requiring http/2 will fail.
[task 2018-03-19T23:27:01.623Z] 23:27:01     INFO - E   Running tests sequentially.
[task 2018-03-19T23:27:01.623Z] 23:27:01     INFO - E   SUITE-START | Running 1 tests
[task 2018-03-19T23:27:01.623Z] 23:27:01     INFO - E   TEST-START | test_tasks_skipall.js
[task 2018-03-19T23:27:01.623Z] 23:27:01  WARNING - E   TEST-UNEXPECTED-FAIL | test_tasks_skipall.js | xpcshell return code: -11
[task 2018-03-19T23:27:01.623Z] 23:27:01     INFO - E   TEST-INFO took 156ms
[task 2018-03-19T23:27:01.623Z] 23:27:01     INFO - E   >>>>>>>
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | [6512, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 508
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | Assertion failure: aDefaultLocale.IsEmpty() || Locale(aDefaultLocale).IsValid() (If specified, default locale must be a valid BCP47 language tag.), at /builds/worker/workspace/build/src/intl/locale/LocaleService.cpp:516
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | #01: mozilla::intl::LocaleService::NegotiateLanguages [intl/locale/LocaleService.cpp:515]
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | #02: mozilla::intl::LocaleService::NegotiateAppLocales [xpcom/ds/nsTArray.h:2322]
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | #03: mozilla::intl::LocaleService::GetAppLocaleAsLangTag [intl/locale/LocaleService.cpp:750]
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | #04: nsChromeRegistryChrome::ChromePackageFromPackageEntry [chrome/nsChromeRegistryChrome.cpp:408]
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | #05: nsChromeRegistryChrome::ManifestLocale [chrome/nsChromeRegistryChrome.cpp:727]
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | #06: ParseManifest [xpcom/components/ManifestParser.cpp:734]
[task 2018-03-19T23:27:01.624Z] 23:27:01     INFO - E   PID 6512 | #07: DoRegisterManifest [xpcom/string/nsTSubstring.h:77]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #08: nsComponentManagerImpl::ManifestManifest [xpcom/components/nsComponentManager.cpp:565]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #09: ParseManifest [xpcom/components/ManifestParser.cpp:743]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #10: DoRegisterManifest [xpcom/string/nsTSubstring.h:77]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #11: nsComponentManagerImpl::RereadChromeManifests [xpcom/components/nsComponentManager.cpp:557]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #12: nsComponentManagerImpl::Init [xpcom/components/nsComponentManager.cpp:345]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #13: NS_InitXPCOM2 [xpcom/build/XPCOMInit.cpp:677]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #14: XRE_XPCShellMain [xpcom/base/nsCOMPtr.h:787]
[task 2018-03-19T23:27:01.625Z] 23:27:01     INFO - E   PID 6512 | #15: mozilla::BootstrapImpl::XRE_XPCShellMain [toolkit/xre/Bootstrap.cpp:57]
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   PID 6512 | #16: main [js/xpconnect/shell/xpcshell.cpp:67]
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   PID 6512 | #17: libc.so.6 + 0x1eead
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   PID 6512 | #18: _start
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   PID 6512 | ExceptionHandler::GenerateDump cloned child 6517
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   PID 6512 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   PID 6512 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   <<<<<<<
[task 2018-03-19T23:27:01.626Z] 23:27:01     INFO - E   INFO | Result summary:
[task 2018-03-19T23:27:01.627Z] 23:27:01     INFO - E   INFO | Passed: 0
[task 2018-03-19T23:27:01.627Z] 23:27:01     INFO - E   INFO | Failed: 1
[task 2018-03-19T23:27:01.627Z] 23:27:01     INFO - E   INFO | Todo: 0
[task 2018-03-19T23:27:01.627Z] 23:27:01     INFO - E   INFO | Retried: 0
[task 2018-03-19T23:27:01.627Z] 23:27:01     INFO - E   SUITE-END | took 0s
Summary: Intermittent ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskSkip TEST-UNEXPECTED-FAIL → Permafailing tier2 busage ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskSkip TEST-UNEXPECTED-FAIL
Linux ccov builds are broken because of this. I think it has started since https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=48f43d2ad95ec075addce039f7fe7dcd8edbaf61.
Ha! That's the same issue as Jorg was tracing for Thunderbird in bug 1447589 (CCing).

Ok, so similarly to that bug 1447589 I have no idea what's going on and why the default locale is set and not valid.

The patch is not critical so I can back it out but my worry is that it will not tell us why do we pass an invalid locale here where we definitely shouldn't.

Without it there may be a deeper hidden bug that will cause even more esoteric failures and we will spend way more time to debug it.

So, instead of backing it out I'd like to understand why this assertion failure, what's the value of `aDefaultLocale` when it does and why `update.locale` file in this build sets it so badly. (that's where the `aDefaultLocale` comes from).

I may need some help with that as I never debugged builds like this. Who should I set NI's on?
See Also: → 1447589
Since our builds work again, I was just going to do you a try run with the prints discussed in bug 1447589 comment #1. Coming up.
Hmm, I further don't understand. I downloaded `target.tar.bz2` from https://tools.taskcluster.net/groups/XeMOMDQeSKKKzwfBLwlYNA/tasks/CR_L8p-5RkGsmHFf-CBE4Q/runs/0/artifacts

and its `update.locale` has `en-US`. I was also able to start the build without any issues and this seems like a startup bug based on the stack:

```
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | Assertion failure: aDefaultLocale.IsEmpty() || Locale(aDefaultLocale).IsValid() (If specified, default locale must be a valid BCP47 language tag.), at /builds/worker/workspace/build/src/intl/locale/LocaleService.cpp:516
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #01: mozilla::intl::LocaleService::NegotiateLanguages [intl/locale/LocaleService.cpp:515]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #02: mozilla::intl::LocaleService::NegotiateAppLocales [xpcom/ds/nsTArray.h:2322]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #03: mozilla::intl::LocaleService::GetAppLocaleAsLangTag [intl/locale/LocaleService.cpp:750]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #04: nsChromeRegistryChrome::ChromePackageFromPackageEntry [chrome/nsChromeRegistryChrome.cpp:408]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #05: nsChromeRegistryChrome::ManifestLocale [chrome/nsChromeRegistryChrome.cpp:727]
[task 2018-03-19T23:27:01.617Z] 23:27:01     INFO - E   PID 6497 | #06: ParseManifest [xpcom/components/ManifestParser.cpp:734]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #07: DoRegisterManifest [xpcom/string/nsTSubstring.h:77]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #08: nsComponentManagerImpl::ManifestManifest [xpcom/components/nsComponentManager.cpp:565]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #09: ParseManifest [xpcom/components/ManifestParser.cpp:743]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #10: DoRegisterManifest [xpcom/string/nsTSubstring.h:77]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #11: nsComponentManagerImpl::RereadChromeManifests [xpcom/components/nsComponentManager.cpp:557]
[task 2018-03-19T23:27:01.618Z] 23:27:01     INFO - E   PID 6497 | #12: nsComponentManagerImpl::Init [xpcom/components/nsComponentManager.cpp:345]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #13: NS_InitXPCOM2 [xpcom/build/XPCOMInit.cpp:677]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #14: XRE_XPCShellMain [xpcom/base/nsCOMPtr.h:787]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #15: mozilla::BootstrapImpl::XRE_XPCShellMain [toolkit/xre/Bootstrap.cpp:57]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #16: main [js/xpconnect/shell/xpcshell.cpp:67]
[task 2018-03-19T23:27:01.619Z] 23:27:01     INFO - E   PID 6497 | #17: libc.so.
```

I have no clue what to do here :(
Maybe :sparky can help you.

You can trigger coverage builds easily with "./mach try fuzzy" and selecting "build-linux64-ccov" (or something similar, I don't have access to a dev environment right now).

If you think the investigation will take long, I'd suggest backing out the patch temporarily.
Flags: needinfo?(gmierz2)
> If you think the investigation will take long, I'd suggest backing out the patch temporarily.

Until I can reproduce it, backing it out will make it impossible to fix. I did not manage to reproduce it yet.

It doesn't happen on any user facing build, tier 1 or other tests, so I'm reluctant to back out a patch that adds assertion for sanity reasons which fails on a single type of tier 2 test build until I understand why this build fails.

My comment about backing out was rather meant to suggest that we can back it out if all else fails, than to back it out now and then leave me trying to figure out why one build acts in a non-correct way.

This patch doesn't change any code paths, it just tightens the checks around code that already exist. Which means that backing it out will hide the bug in this run. Would you you recommend doing that?
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #7)
> > If you think the investigation will take long, I'd suggest backing out the patch temporarily.
> 
> Until I can reproduce it, backing it out will make it impossible to fix. I
> did not manage to reproduce it yet.
> 
> It doesn't happen on any user facing build, tier 1 or other tests, so I'm
> reluctant to back out a patch that adds assertion for sanity reasons which
> fails on a single type of tier 2 test build until I understand why this
> build fails.
> 
> My comment about backing out was rather meant to suggest that we can back it
> out if all else fails, than to back it out now and then leave me trying to
> figure out why one build acts in a non-correct way.
> 
> This patch doesn't change any code paths, it just tightens the checks around
> code that already exist. Which means that backing it out will hide the bug
> in this run. Would you you recommend doing that?

Can you reproduce it in a try build? I would expect there to be no difference between a try build and a mozilla-central one for this.
If you can reproduce in a try build, you can backout the patch and apply it only for try.

If you want to run some basic sanity checks that don't require changing the code, you can get a one-click loaner for the build from treeherder.

I suggest backing out only if you think the investigation will take long, we have already lost two days of coverage data and I'd prefer to avoid losing more (provided you can reproduce it in a try build, if you can't then I agree there's more priority in seeing this fixed since the assertion is supposed to pass).
> Can you reproduce it in a try build? I would expect there to be no difference between a try build and a mozilla-central one for this.

Trying now!


> If you can reproduce in a try build, you can backout the patch and apply it only for try.

Yeah, that's my plan - once I can reproduce it I'll asses if I need to back out.

> I suggest backing out only if you think the investigation will take long, we have already lost two days of coverage data and I'd prefer to avoid losing more

Yep, cool. We agree.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
(In reply to Jorg K (GMT+1) from comment #8)
> I'll return to check the logs later.

This what I get:
[task 2018-03-22T19:04:24.328Z] 19:04:24     INFO - E   PID 23646 | === ***
[task 2018-03-22T19:04:24.328Z] 19:04:24     INFO - E   PID 23646 | === ***
[task 2018-03-22T19:04:24.329Z] 19:04:24     INFO - E   PID 23646 | === *** (1) x-test
[task 2018-03-22T19:04:24.329Z] 19:04:24     INFO - E   PID 23646 | === ***
[task 2018-03-22T19:04:24.329Z] 19:04:24     INFO - E   PID 23646 | === ***
[task 2018-03-22T19:04:24.329Z] 19:04:24     INFO - E   PID 23646 | === ***
[task 2018-03-22T19:04:24.329Z] 19:04:24     INFO - E   PID 23646 | === ***
[task 2018-03-22T19:04:24.329Z] 19:04:24     INFO - E   PID 23646 | === *** (2) x-test
[task 2018-03-22T19:04:24.329Z] 19:04:24     INFO - E   PID 23646 | === ***
[task 2018-03-22T19:04:24.330Z] 19:04:24     INFO - E   PID 23646 | === ***

Now, x-test doesn't look like a very good locale to me :-(
https://taskcluster-artifacts.net/Mtmf4IgKSA-nZNw3L5uysA/0/public/logs/live_backing.log
Ohh! That's brilliant! That's an easy fix then :)

Per RFC: "The single-character subtag 'x' as the primary subtag indicates that the language tag consists solely of subtags whose meaning is defined by private agreement"

Thank you Jorg so much!
Flags: needinfo?(gmierz2)
See Also: 1447589
This is a nice fix to what might have been a nasty bug to debug. Thanks Jorg!

The patch does two things:

1) Adds support for BCP47 private use tags
2) Adds a test that matches the assertion (that the defaultlocale is not empty and is valid).

The (2) should help us not hit this ever in the future since the test will blow on any build.
Comment on attachment 8961569 [details]
Bug 1447189 - Support BCP47 private use subtags in MozLocale.

https://reviewboard.mozilla.org/r/230428/#review236062

One question that comes to mind: is it OK for us to sort the private use subtags? We do this for variant subtags, where IIRC ordering is not considered significant, but is that a safe assumption for the private case? Given that the meaning of a series of private use subtags is defined by private agreement (and unknown to our code), it seems possible that someone might care about the distinction between x-foo-bar and x-bar-foo.
Great catch! Fixed! :)
Comment on attachment 8961569 [details]
Bug 1447189 - Support BCP47 private use subtags in MozLocale.

https://reviewboard.mozilla.org/r/230428/#review236212

OK, seems reasonable. I'm a bit sad that our Locale object ends up carrying around so many members that in practice will almost always be empty, but I don't have a good alternative in mind at the moment.
Attachment #8961569 - Flags: review?(jfkthame) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da7824ea1a62
Support BCP47 private use subtags in MozLocale. r=jfkthame
> OK, seems reasonable. I'm a bit sad that our Locale object ends up carrying around so many members that in practice will almost always be empty, but I don't have a good alternative in mind at the moment.

Is that a memory issue or performance issue? I'd like to keep the Locale object memory lightweight if possible, but BCP47 has a number of fields on its data struct and we should reproduce it if possible.

In Rust we'd use sth like:

```
struct Locale {
  language: Option(String),
  script: Option(String),
  region: Option(String),
  variants: Option(Vec<String>),
  privateuse: Option(Vec<String>),
}
```

is there an equivalent of that in C++ that would help us?
Flags: needinfo?(jfkthame)
That may be a nice idiom, but I doubt it ends up any more lightweight once it's compiled; e.g. initializing an nsTArray<T> as empty isn't so very different from initializing an Option(T) to None.
Flags: needinfo?(jfkthame)
Option<String> is represented as a (ptr, cap, len) where the ptr can be null. Option<Vec> works the same way. So there's no allocation in the None case, and Option<String> doesn't take up more space than String. AIUI nsTArray initialized to empty works similarly.
https://hg.mozilla.org/mozilla-central/rev/da7824ea1a62
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1448891
See Also: → 1471769
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: