1447190 - Remove internal mutability from nsStandardURL

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

nsStandardURL is mostly immutable at this point, at least externally.
But for it to be threadsafe, it needs to be internally immutable as well, meaning there needs to be no lazy initialization triggered by getters.

mSpecEncoding is one such example. It seems it can be removed completely, as the spec is always ASCII encoded.
mDisplayHost is another. This can be fixed by always updating mDisplayHost when changing the host.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1447190 - Remove internal mutability from nsStandardURL

* Removes mSpecEncoding since the spec is always ASCII encoded
* nsStandardURL::InitGlobalObjects is now called from nsNetStartup
* Removes prefObserver from nsStandardURL
* mDisplayHost is now initialized every time that we change the hostname
* Adds locking to the gAllURLs list

Review commit: https://reviewboard.mozilla.org/r/229332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229332/

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8960586 [details]
Bug 1447190 - Remove internal mutability from nsStandardURL

https://reviewboard.mozilla.org/r/229332/#review235626

::: netwerk/base/nsStandardURL.cpp:216
(Diff revision 1)
> +
> +#ifdef DEBUG_DUMP_URLS_AT_SHUTDOWN
> +    StaticMutexAutoLock lock(gAllURLsMutex);
> +    if (isInList()) {
> +      remove();
> +    }

nit: please add the code in the #ifdef block to a { }, so that when someone adds something it's not locked when defined

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8960586 [details]
Bug 1447190 - Remove internal mutability from nsStandardURL

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229332/diff/1-2/

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8960586 [details]
Bug 1447190 - Remove internal mutability from nsStandardURL

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229332/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f6e0c390b40
Remove internal mutability from nsStandardURL r=mayhemer

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5f6e0c390b40