1447312 - [Dark theme] Windows Aero showing between toolbars and content area

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[tux16090]

Attachment: 1.PNG

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180320100122

Steps to reproduce:

Open up any dark webpage, IE blackberry.com, duckduckgo.com with its dark theme, or just any dark page in general you can really see it. It can be seen in a regular webpage, just not as noticeable as on a dark webpage for me. Note, the firefox dark theme is enable as well. 


Actual results:

Windows Aero is showing through at the very top of the webpage. 


Expected results:

Windows Aero should not be viable at the very top of the webpage.

Comment 1

[Dão Gottwald [:dao]]

This is because --toolbox-border-bottom-color has transparency:

https://searchfox.org/mozilla-central/rev/59a9a86553e9bfd9277202748ff791fd9bc0713b/browser/themes/shared/compacttheme.inc.css#23

We should make it opaque instead by setting it to hsl(240, 4%, 5%).

Comment 2

[Jens Hausdorf :jens1o [ni? me]]

I'd like to work on it. :)

Is that okay for you Dao?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Jens Hausdorf from comment #2)
> I'd like to work on it. :)
> 
> Is that okay for you Dao?

Sure!

Comment 4

[Jens Hausdorf :jens1o [ni? me]]

Attachment: 1447312.patch

Unfortunately I'm still not able to autoreview using the review board, so I'll attach it here, sorry!

I'm still getting the same result as here: https://bugzilla.mozilla.org/show_bug.cgi?id=1442442#c17

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8969879 [details] [diff] [review]
1447312.patch

This patch doesn't apply cleanly. Please update your mozilla-central clone.

applying https://bug1447312.bmoattachments.org/attachment.cgi?id=8969879
patching file browser/themes/shared/compacttheme.inc.css
Hunk #1 FAILED at 14
1 out of 1 hunks FAILED -- saving rejects to file browser/themes/shared/compacttheme.inc.css.rej
abort: patch failed to apply

Comment 6

[Jens Hausdorf :jens1o [ni? me]]

Noob question incoming.
-
$ hg update
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
updated to "9e38e1aa20c2: Bug 1447312 - Remove opacity filter from toolbox-borde
r-bottom-color in photon dark theme to avoid the Windows Aero background to shin
e through r?dao"
1 other heads for branch "default"

-

How do I switch heads? I'm used to git and I didn't see any merge conflict?

Comment 7

[Dão Gottwald [:dao]]

You're not seeing conflicts because hg didn't even try to merge, it just created a new head for your commit. hg supports a number of different workflows so I'm not sure what works in your case. I would normally do hg update --rebase to rebase existing local commits, but now that you already have added another head, you may have to remove that first, e.g. using hg strip.

Comment 8

[Jens Hausdorf :jens1o [ni? me]]

Alright. Thanks for your input. I'm going to do that at the weekend for time reasons. :)

Comment 9

[Jens Hausdorf :jens1o [ni? me]]

Attachment: 1447312.patch

Next try. Sorry, I've got a long weekend due to public holiday in Germany

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8972406 [details] [diff] [review]
1447312.patch

(In reply to Jens Hausdorf from comment #9)
> Created attachment 8972406 [details] [diff] [review]
> 1447312.patch
> 
> Next try. Sorry, I've got a long weekend due to public holiday in Germany

Same here, I'm Berlin based. :)

This patch applies fine. Thanks! Going to push it in a bit.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb4c2185ba01
Remove opacity filter from toolbox-border-bottom-color in photon dark theme to avoid the Windows Aero background to shine through r=dao

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fb4c2185ba01