1447315 - fix py.test warnings in backend tests from upgraded dependencies

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Description

[[e-mail] (:bhearsum)]

We recently updated most of our dependencies, and the new flake8 is throwing a bunch of new warnings. They can be seen in logs such as https://taskcluster-artifacts.net/BW9QlMpERfC91iaIEvimmg/0/public/logs/live_backing.log

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

There's no 'warnings summary' section in the backend tests for the last push to master, see https://taskcluster-artifacts.net/QDvoN_gxQj-dbzVsqTN5mQ/0/public/logs/live_backing.log, but that seems to be because DeprecationWarning and PendingDeprecationWarning are suppressed by py.test as of 3.1. It shows all other warnings, see https://docs.pytest.org/en/latest/warnings.html for more info.

You can make them show up again with:
diff --git a/tox.ini b/tox.ini
index 9fca8d8..57885e2 100644
--- a/tox.ini
+++ b/tox.ini
@@ -11,7 +11,7 @@ deps = -rrequirements-test.txt

 commands=
     flake8 auslib scripts uwsgi
-    py.test -n2 --cov=auslib --doctest-modules {posargs:auslib}
+    py.test -W default::DeprecationWarning -W default::PendingDeprecationWarning -n2 --cov=auslib --doctest-modules {posargs:auslib}
     coverage run -a scripts/test-rules.py

 [testenv:py27]

Comment 2

[Allan [:asilva]]

Attachment: PR for review

Taskcluster log: https://taskcluster-artifacts.net/QUQPPlQURzm3BOwEQ0OnAQ/0/public/logs/live_backing.log

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Landed at https://github.com/mozilla/balrog/commit/1ed210d34baaa58cbe1bc2fbf330b148d03a2032, thanks for all the effort here.