1447318 - make code python 3 compatible

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

Make sure we're not using any python3 reserved words, no print statements, use python 3 exceptions/classes, etc.

Comment 1

[[e-mail] (:bhearsum)]

Running pylint or flake8 is probably a good way to get started looking for issues here. Eg:
➜  balrog git:(master) flake8 auslib/db.py
auslib/db.py:221:29: E999 SyntaxError: invalid syntax
                raise exc[0], exc[1], exc[2]
                            ^

Comment 2

[[e-mail] (:bhearsum)]

Collins, are you still planning to take a look at this soon? If not, can we re-assign to Allan?

Comment 3

[Collins Abitekaniza]

I think I will let go of this, Going to be a bit busy for the next coming days.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/5ad22097f72fb6268f3cc76ccbea98714d613fa1
bug 1447318: make code python 3 compatible (#621). r=bhearsum

Comment 5

[[e-mail] (:bhearsum)]

This merged to production yesterday. The code is now Python 3 compatible (with CI verifying that) - so we should be ready to talk about upgrading production at any point now.

Thank you for all of your work here, Allan!

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

We did a first prod push today, retaining py2 for admin/web. At some point in the near future we can work with CloudOps to spin up a canary in prod using py3 for the web component. Looks like we'll need to figure out how to generate a docker image for that first.