Closed
Bug 1447391
Opened 6 years ago
Closed 6 years ago
Excessive time spent in GCCellPtr::mayBeOwnedByOtherRuntimeSlow()
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla61
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(1 file)
1.96 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
jesup was looking at a profile that takes 863ms out of a several-second CC in the above function.
Assignee | ||
Comment 1•6 years ago
|
||
We only need to do mayBeOwnedByOtherRuntimeSlow for strings and symbols, neither of which can be a member of a cycle.
Attachment #8960700 -
Flags: review?(continuation)
Assignee | ||
Comment 2•6 years ago
|
||
The profile is https://perf-html.io/public/4e702d827135a52bf292c4e5035bb4748051d3fb/calltree/?hiddenThreads=&range=91.6517_100.0366&thread=5&threadOrder=0-2-3-4-5-6-8-9-1-7&v=3 and was posted on reddit at https://www.reddit.com/r/firefox/comments/85lqf9/random_stutters_and_lags_in_600b4/
Comment 3•6 years ago
|
||
Comment on attachment 8960700 [details] [diff] [review] Early return for strings and symbols when tracing for CC Review of attachment 8960700 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for investigating and fixing this.
Attachment #8960700 -
Flags: review?(continuation) → review+
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a65fcbcfe819 Early return for strings and symbols when tracing for CC, r=mccr8
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a65fcbcfe819
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 7•6 years ago
|
||
[Tracking Requested - why for this release]: Users are seeing severe performance problems in Firefox 60 that would be helped by this patch. It isn't clear if this is a complete solution or not. (for example: https://www.reddit.com/r/firefox/comments/8if1fs/anyone_else_seeing_massive_cpu_spikes_with_ff_60/ )
Updated•6 years ago
|
status-firefox-esr60:
--- → affected
tracking-firefox-esr60:
--- → ?
Comment 8•6 years ago
|
||
One user on Reddit was still experiencing problems with Firefox 62, so this may not fix the worst of it. https://www.reddit.com/r/firefox/comments/8if1fs/anyone_else_seeing_massive_cpu_spikes_with_ff_60/dyrh099/
Comment 9•6 years ago
|
||
Per IRC discussion with mccr8, it doesn't appear that we need to backport this to 60 after all.
tracking-firefox60:
? → ---
tracking-firefox-esr60:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•