Closed Bug 1447457 Opened 2 years ago Closed 2 years ago

Remove workarounds for VS2010 from js/src/jit

Categories

(Core :: JavaScript Engine: JIT, enhancement, trivial)

enhancement
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: sunfish, Assigned: sunfish)

References

Details

Attachments

(1 file, 1 obsolete file)

This patch removes a few workarounds for MSVC 2010 originally added by bug 991153. According to RyanVM, we only support MSVC 2017 now, and the tests appear to pass without the workaround now:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=310156a605df01f59afedccaa45112d05756263d
Attachment #8960783 - Flags: review?(bbouvier)
Assignee: nobody → sunfish
Comment on attachment 8960783 [details] [diff] [review]
remove-msvc-2010-bug-workaround.patch

Review of attachment 8960783 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!

::: js/src/jit/RegisterSets.h
@@ +76,2 @@
>          } else {
> +            ret = AnyRegister(gpr().aliased(aliasIdx));

nit: no braces for single-line if/else

::: js/src/jit/arm/Architecture-arm.h
@@ +502,2 @@
>          if (aliasIdx == 0) {
> +            return *this;

nit: no braces for single-line if

@@ +529,2 @@
>          if (aliasIdx == 0) {
> +            return *this;

nit: no braces for single-line if

::: js/src/jit/arm64/Architecture-arm64.h
@@ +389,2 @@
>          else
> +            return FloatRegister(code_, otherkind(k_));

nit: else after return

::: js/src/jit/mips32/Architecture-mips32.h
@@ +192,4 @@
>          MOZ_ASSERT(isNotOdd());
>  
>          if (aliasIdx == 0) {
> +            return *this;

nit: braces

@@ +200,2 @@
>          } else {
> +            return doubleOverlay();

nit: else after return, no braces

@@ +209,4 @@
>          MOZ_ASSERT(isNotOdd());
>  
>          if (aliasIdx == 0) {
> +            return *this;

nit: braces

@@ +217,2 @@
>          } else {
> +            return doubleOverlay();

nit: etc

::: js/src/jit/mips64/Architecture-mips64.h
@@ +175,2 @@
>          if (aliasIdx == 0) {
> +            return *this;

ditto

@@ +181,2 @@
>          else
> +          return doubleOverlay();

ditto

@@ +188,3 @@
>          MOZ_ASSERT(isDouble());
>          if (aliasIdx == 0) {
> +            return *this;

ditto
Attachment #8960783 - Flags: review?(bbouvier) → review+
Comments addressed. Carrying forward r+.
Attachment #8960783 - Attachment is obsolete: true
Attachment #8962838 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9b7fe99807c
SpiderMonkey: Remove MSVC 2010 bug workarounds. r=bbouvier
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d9b7fe99807c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.