Closed Bug 1447475 Opened 5 years ago Closed 5 years ago

Remove MOZ_ICU_DATA_ARCHIVE and all code related to its being non-empty


(Firefox Build System :: General, enhancement)

3 Branch
Not set


(firefox61 fixed)

Tracking Status
firefox61 --- fixed


(Reporter: Waldo, Assigned: Waldo)



(1 file)

Bug 1445524 made it so when ICU is in the build, ICU data is directly embedded into the binary -- never stored in a separate file.  (This was previously desirable for Mac universal builds -- builds we can't do now and haven't done for a year.)  We did so by unconditionally setting |MOZ_ICU_DATA_ARCHIVE=|.  A bunch of code still exists for the non-empty setting, and it should be removed.

I feel duty-bound to observe that bug 926980 indicates that Tenfourfox (PPC) wants the separate-file behavior for arch-specific reasons.  But we're not required to care about them as tier-N>1.  Moreover, this change makes life *easier* for big-endian tier-N>1 platforms, as we only have a little-endian ICU .dat file in our tree.  Tenfourfox has no greater right to obsolete hackarounds than any other tier-N>1 build.

There's probably more that can be removed here -- we should be able to generate the .dat at compile time, IMO, rather than having to prebuild it and check a big thing into the tree -- but these are the obvious bits of removal I can do quickly.  I'm not sure what needs to be done to get rid of the .dat and all to just let ICU compile this stuff in naturally.
Attachment #8961139 - Flags: review?(ted)
Assignee: nobody → jwalden+bmo
FWIW, I settled on checking the file into the tree because building it required building a bunch of ICU host tools, which was kind of a nightmare (and worse for cross-compiles).
Comment on attachment 8961139 [details] [diff] [review]
Rip out various MOZ_ICU_DATA_ARCHIVE-related code

Review of attachment 8961139 [details] [diff] [review]:

Well that certainly simplifies things a bit. Thanks!
Attachment #8961139 - Flags: review?(ted) → review+
Pushed by
Rip out support code for setting MOZ_ICU_DATA_ARCHIVE and shipping ICU data in a file outside the binary.  r=ted
Problematic push:

task 2018-03-27T22:04:11.783Z] 22:04:11     INFO -  TypeError: coercing to Unicode: need string or buffer, NoneType found
[task 2018-03-27T22:04:14.338Z] 22:04:14     INFO -  --DOCSHELL 0x7f1df2dbe800 == 5 [pid = 804] [id = {13731511-00ec-4136-86d1-f33d31cd325d}]
[task 2018-03-27T22:04:19.077Z] 22:04:19     INFO -  --DOMWINDOW == 15 (0x7f1dfc0ab800) [pid = 804] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2018-03-27T22:04:19.079Z] 22:04:19     INFO -  --DOMWINDOW == 14 (0x7f1de965f400) [pid = 804] [serial = 12] [outer = (nil)] [url = about:blank]
[task 2018-03-27T22:04:19.079Z] 22:04:19     INFO -  --DOMWINDOW == 13 (0x7f1de965f000) [pid = 804] [serial = 11] [outer = (nil)] [url = about:blank]
[task 2018-03-27T22:04:19.080Z] 22:04:19     INFO -  --DOMWINDOW == 12 (0x7f1deee92800) [pid = 804] [serial = 15] [outer = (nil)] [url = about:blank]
[task 2018-03-27T22:04:22.762Z] 22:04:22     INFO -  --DOMWINDOW == 11 (0x7f1df2d0d800) [pid = 804] [serial = 7] [outer = (nil)] [url = about:blank]
[task 2018-03-27T22:04:22.823Z] 22:04:22     INFO -  --DOMWINDOW == 2 (0x7fa81b70e800) [pid = 846] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2018-03-27T22:04:28.826Z] 22:04:28     INFO -  --DOMWINDOW == 10 (0x7f1df1ccc000) [pid = 804] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2018-03-27T22:04:29.025Z] 22:04:29     INFO -  [Parent 804, StreamTrans #33] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/modules/libjar/nsJARChannel.cpp, line 428
[task 2018-03-27T22:21:09.060Z] 22:21:09     INFO - Automation Error: mozprocess timed out after 1000 seconds running ['/builds/worker/workspace/build/venv/bin/python', '-u', '/builds/worker/workspace/build/tests/marionette/harness/marionette_harness/', '--headless', '--gecko-log=-', '--log-raw=-', '-vv', '--log-raw=/builds/worker/workspace/build/blobber_upload_dir/marionette_raw.log', '--log-errorsummary=/builds/worker/workspace/build/blobber_upload_dir/marionette_errorsummary.log', '--log-html=/builds/worker/workspace/build/blobber_upload_dir/report.html', '--binary=/builds/worker/workspace/build/application/firefox/firefox', '--address=localhost:2828', '--symbols-path=/builds/worker/workspace/build/symbols', '/builds/worker/workspace/build/tests/marionette/tests/testing/marionette/harness/marionette_harness/tests/unit-tests.ini']
[task 2018-03-27T22:21:09.071Z] 22:21:09    ERROR - timed out after 1000 seconds of no output
[task 2018-03-27T22:21:09.072Z] 22:21:09    ERROR - Return code: -15
[task 2018-03-27T22:21:09.072Z] 22:21:09    ERROR - No checks run.
[task 2018-03-27T22:21:09.073Z] 22:21:09    ERROR - No suite end message was emitted by this harness.
[task 2018-03-27T22:21:09.074Z] 22:21:09     INFO - TinderboxPrint: marionette<br/><em class="testfail">T-FAIL</em>
[task 2018-03-27T22:21:09.075Z] 22:21:09     INFO - gecko.log not found
[task 2018-03-27T22:21:09.075Z] 22:21:09     INFO - TinderboxPrint: marionette<br/>0/0/0
[task 2018-03-27T22:21:09.077Z] 22:21:09     INFO - Marionette exited with return code -15: FAILURE
[task 2018-03-27T22:21:09.077Z] 22:21:09    ERROR - # TBPL FAILURE #
Flags: needinfo?(jwalden+bmo)
Pushed by
Rip out support code for setting MOZ_ICU_DATA_ARCHIVE and shipping ICU data in a file outside the binary.  r=ted
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Pushed by
Port bug 1447475 [Rip out support code for setting MOZ_ICU_DATA_ARCHIVE and shipping ICU data in a file outside the binary]. rs=bustage-fix CLOSED TREE
Flags: needinfo?(jwalden+bmo)
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.