1447692 - RTCDataChannelEventInit is required

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1447692: update RTCDataChannelEventInit to meet spec.

Review commit: https://reviewboard.mozilla.org/r/229714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229714/

Comment 2

[Nils Ohlmeier [:drno]]

Attachment: Bug 1447692: update WPT tests for RTCDataChannelEventInit.

Review commit: https://reviewboard.mozilla.org/r/229716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229716/

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8960999 [details]
Bug 1447692: update WPT tests for RTCDataChannelEventInit.

https://reviewboard.mozilla.org/r/229716/#review235520

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8960998 [details]
Bug 1447692: update RTCDataChannelEventInit to meet spec.

https://reviewboard.mozilla.org/r/229714/#review235532

Comment 5

[Nils Ohlmeier [:drno]]

Attachment: Bug 1447692: updated WPT interface for RTCDataChannelEvent.

Review commit: https://reviewboard.mozilla.org/r/229792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229792/

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8961046 [details]
Bug 1447692: updated WPT interface for RTCDataChannelEvent.

https://reviewboard.mozilla.org/r/229792/#review235612

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72e826d418db
update RTCDataChannelEventInit to meet spec. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a0e6d3b75ff0
update WPT tests for RTCDataChannelEventInit. r=jib
https://hg.mozilla.org/integration/autoland/rev/13ef15a9aacc
updated WPT interface for RTCDataChannelEvent. r=jib

Comment 8

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1447692) for Mochitest failures on dom/events/test/test_all_synthetic_events.html

Log of the fail:
https://treeherder.mozilla.org/logviewer.html#?job_id=169555344&repo=autoland&lineNumber=1639

 TEST-START | dom/events/test/test_all_synthetic_events.html
15:23:35     INFO - TEST-INFO | started process screencapture
15:23:35     INFO - TEST-INFO | screencapture: exit 0
15:23:35     INFO - Buffered messages logged at 15:23:35
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating SpeechSynthesisErrorEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating BeforeUnloadEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating CustomEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating PageTransitionEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating PopupBlockedEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating CloseEvent... 
15:23:35     INFO - TEST-FAIL | dom/events/test/test_all_synthetic_events.html | Cannot create untrusted event of RTCTrackEvent 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating ProgressEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating MessageEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating FocusEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating SecurityPolicyViolationEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating DeviceMotionEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating TouchEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating TimeEvent... 
15:23:35     INFO - TEST-PASS | dom/events/test/test_all_synthetic_events.html | Creating RTCDataChannelEvent... 
15:23:35     INFO - Buffered messages finished
15:23:35     INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_all_synthetic_events.html | uncaught exception - TypeError: Missing required 'channel' member of RTCDataChannelEventInit. at create@http://mochi.test:8888/tests/dom/events/test/test_all_synthetic_events.html:292:65
15:23:35     INFO - @http://mochi.test:8888/tests/dom/events/test/test_all_synthetic_events.html:445:15
15:23:35     INFO - 

Backout:
https://hg.mozilla.org/integration/autoland/rev/64bcc9693c4971d3f76954727e7f6dbecc2f17cf

Push that got backed out:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=13ef15a9aacce6605cb1f60b610191e27271bee0

Comment 9

[Nils Ohlmeier [:drno]]

Attachment: Bug 1447692: updated synthetic_events test to match new RTCDataChannelEvent.

Review commit: https://reviewboard.mozilla.org/r/229990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229990/

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8961220 [details]
Bug 1447692: updated synthetic_events test to match new RTCDataChannelEvent.

https://reviewboard.mozilla.org/r/229990/#review235694

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f163b5f1ac6
update RTCDataChannelEventInit to meet spec. r=smaug
https://hg.mozilla.org/integration/autoland/rev/5f0d610a7a02
update WPT tests for RTCDataChannelEventInit. r=jib
https://hg.mozilla.org/integration/autoland/rev/8635ff10ad0e
updated WPT interface for RTCDataChannelEvent. r=jib
https://hg.mozilla.org/integration/autoland/rev/a70e72baf607
updated synthetic_events test to match new RTCDataChannelEvent. r=jib

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4f163b5f1ac6
https://hg.mozilla.org/mozilla-central/rev/5f0d610a7a02
https://hg.mozilla.org/mozilla-central/rev/8635ff10ad0e
https://hg.mozilla.org/mozilla-central/rev/a70e72baf607

Comment 13

[Chris Mills [:cmills]]

Setting straight to dev-doc-complete — I've checked, and our docs already list the relevant features as required.