1447729 - Specify support library via gradle instead of moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We no longer need to support the old mozbuild build path, so we can specify this dependency the normal way.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1447729 - Specify Android support lib dependency in gradle

Review commit: https://reviewboard.mozilla.org/r/229778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229778/

Comment 2

[Nick Alexander :nalexander [he/him]]

This is easy: remove https://searchfox.org/mozilla-central/source/mobile/android/moz.configure#119 and the old_configure assignment.

Expose the version to all projects, like at https://searchfox.org/mozilla-central/source/build.gradle#20

Replace the occurrences in build.gradle files with the exposed version.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8961027 [details]
Bug 1447729 - Specify Android support lib dependency in gradle

https://reviewboard.mozilla.org/r/229778/#review235572

If it's green on try, it's good for me.  Capitilize Gradle in the commit message, please.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d763eb7eb2f85282b1c0f59f962004f689ba3c7

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e43e49725fef
Specify Android Support library version in Gradle r=nalexander

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e43e49725fef