1447804 - Normandy client should handle IO errors when reading telemetry pings

Status: NEW

(Firefox :: Normandy Client, defect)

Description

[Michael Cooper [:mythmon]]

This bug was automatically filed from Sentry: https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/3319576/

It seems that when loading telemetry pings for the filter expression context, we don't handle errors while reading pings.

Error: 1521592533158	app.normandy.recipe-runner	ERROR	Error checking filter for "Pref Flip - Search Composition new users in Release 57 - Bug 1413565". Filter: [(
    [normandy.userId]|bucketSample(10, 990, 1000)  
    && normandy.channel == 'release'
    && normandy.version >= '57.0'
    &&  ((!normandy.telemetry.main.environment.profile.creationDate && normandy.isFirstRun) || normandy.telemetry.main.environment.profile.creationDate > 17483)
    && 'browser.search.widget.inNavBar'|preferenceValue == false
)]. Error: "PingReadError: uncaught exception: Buffer is too short (no header) - Data: <redacte profile path>/datareporting/archived/2018-03/<redacted>.saved-session.jsonlz4"
    at App_append(undefined:797:9)
    at log(undefined:435:7)
    at error(undefined:443:5)
    at checkFilter(undefined:342:7)
    at throw(undefined:1230:9)