Closed
Bug 1447825
Opened 7 years ago
Closed 7 years ago
Check sslBuffer_Append in ssl_CallCustomExtensionSenders
Categories
(NSS :: Libraries, enhancement, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jcj, Assigned: jcj)
References
Details
Attachments
(1 file)
Coverity caught that at the end of ssl_CallCustomExtensionSenders, a call to sslBuffer_Append doesn't check whether it has hit an error (OOM), while all other usages do.
Since cleanup is the same, it's really just a matter of error propagation. We should be consistent.
|
||
Comment 1•7 years ago
|
||
|
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8961195 [details]
Bug 1447825 - Check sslBuffer_Append in ssl_CallCustomExtensionSenders r?mt
Martin Thomson [:mt:] has approved the revision.
https://phabricator.services.mozilla.com/D788
Attachment #8961195 -
Flags: review+
|
Assignee | |
Comment 3•7 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•