1447829 - Intermittent browser/base/content/test/sync/browser_sync.js | button tooltiptext is set to the right value - Got Last sync: now, expected Last sync: 1 sec. ago

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: dluca [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=169489169&repo=autoland

https://queue.taskcluster.net/v1/task/FQ0t0DpIQXi5MigBFkDmEQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1447829 - Fix the "now" anchor for relative date in browser_sync.js test.

Review commit: https://reviewboard.mozilla.org/r/230436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230436/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8961571 [details]
Bug 1447829 - Fix the "now" anchor for relative date in browser_sync.js test.

https://reviewboard.mozilla.org/r/230436/#review235932

It might be a bit cleaner if the test could just override relativeTimeFormat to return an object with a formatBestUnit() method that supplies the anchor?

Comment 3

[Edouard Oger [:eoger]]

Comment on attachment 8961571 [details]
Bug 1447829 - Fix the "now" anchor for relative date in browser_sync.js test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230436/diff/1-2/

Comment 4

[Edouard Oger [:eoger]]

Comment on attachment 8961571 [details]
Bug 1447829 - Fix the "now" anchor for relative date in browser_sync.js test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230436/diff/2-3/

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8961571 [details]
Bug 1447829 - Fix the "now" anchor for relative date in browser_sync.js test.

https://reviewboard.mozilla.org/r/230436/#review236880

Awesome, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd1db9734056
Fix the "now" anchor for relative date in browser_sync.js test. r=markh

Comment 7

[Intermittent Failures Robot]

13 failures in 822 pushes (0.016 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 7
* mozilla-inbound: 3
* mozilla-central: 3

Platform breakdown:
* linux64: 7
* osx-10-10: 4
* windows7-32: 1
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1447829&startday=2018-03-20&endday=2018-03-26&tree=trunk

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/dd1db9734056