1447839 - Stop using PathBuilderSkia in PathBuilderRecording

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

We're only using it for implementing CurrentPoint().

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I'm wrong. We use it for other methods too. It's probably better to just use the Skia path internally.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Alternatively, we can create and cache the Skia path on demand when needed for the methods that use it.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1447839 - Avoid creating internal path for PathRecording unless necessary. r?jrmuizel

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1447839 - Avoid creating internal path builder for PathRecording unless necessary. r?jrmuizel

Depends on D172869

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03e8e473943d
Avoid creating internal path for PathRecording unless necessary. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/038ecfe701fb
Avoid creating internal path builder for PathRecording unless necessary. r=jrmuizel

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/03e8e473943d
https://hg.mozilla.org/mozilla-central/rev/038ecfe701fb

Comment 7

[Lee Salzman [:lsalzman]]

Attachment: Bug 1447839 - Directly calculate endpoint in PathBuilderRecording::Arc. r?jrmuizel

The math for directly calculating the endpoint of the arc is actually trivial,
and ArcToBezier is pretty expensive so should be avoided.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/229cb61335bb
Directly calculate endpoint in PathBuilderRecording::Arc. r=jrmuizel,gfx-reviewers

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/229cb61335bb

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)