Closed
Bug 1447859
Opened 7 years ago
Closed 7 years ago
Intermittent toolkit/content/tests/chrome/test_maximized_persist.xul | width should match after restore window - got 200, expected 300
Categories
(Toolkit :: UI Widgets, defect, P5)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: emilio)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:product])
Attachments
(1 file)
662 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Comment hidden (Intermittent Failures Robot) |
Comment 2•7 years ago
|
||
Over the last 7 days there are 31 failures on this bug. These happen on Linux, Linux x64, linux32-nightly, linux64-ccov
Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=170699760&lineNumber=6024
Here is a relevant part of that log:
[task 2018-03-28T00:48:59.997Z] 00:48:59 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_maximized_persist.xul | width should match after restore window - got 200, expected 300
[task 2018-03-28T00:48:59.998Z] 00:48:59 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5
[task 2018-03-28T00:48:59.999Z] 00:48:59 INFO - checkWindow@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_maximized_persist.xul:38:7
[task 2018-03-28T00:48:59.999Z] 00:48:59 INFO - runTest@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_maximized_persist.xul:88:5
[task 2018-03-28T00:49:00.001Z] 00:49:00 INFO - async*onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_maximized_persist.xul:1:1
[task 2018-03-28T00:49:00.001Z] 00:49:00 INFO - rval@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:146:17
[task 2018-03-28T00:49:00.001Z] 00:49:00 INFO - EventHandlerNonNull*this.addLoadEvent@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:171:13
[task 2018-03-28T00:49:00.002Z] 00:49:00 INFO - @chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1444:5
[task 2018-03-28T00:49:00.003Z] 00:49:00 INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-03-28T00:49:00.004Z] 00:49:00 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_maximized_persist.xul | height should match after restore window - got 200, expected 300
Flags: needinfo?(enndeakin)
Updated•7 years ago
|
Whiteboard: [stockwell needswork]
Comment 3•7 years ago
|
||
Probable related to 1446264 and friends.
Blocks: 1446264
Flags: needinfo?(enndeakin) → needinfo?(xidorn+moz)
Comment 4•7 years ago
|
||
It is very likely the same issue as bug 1449166, since this is also a case where we open window in maximized state and then restore it.
Depends on: 1449166
Flags: needinfo?(xidorn+moz)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 7•7 years ago
|
||
We have 52 failures in the last 7 days.
They occur on Linux 32, 64, 64-ccov (asan, debug, opt).
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=172312099&repo=autoland&lineNumber=6018
[task 2018-04-06T15:12:03.625Z] 15:12:03 INFO - Buffered messages finished
[task 2018-04-06T15:12:03.626Z] 15:12:03 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_maximized_persist.xul | width should match after restore window - got 200, expected 300
[task 2018-04-06T15:12:03.626Z] 15:12:03 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5
[task 2018-04-06T15:12:03.627Z] 15:12:03 INFO - checkWindow@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_maximized_persist.xul:38:7
[task 2018-04-06T15:12:03.628Z] 15:12:03 INFO - runTest@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_maximized_persist.xul:88:5
[task 2018-04-06T15:12:03.629Z] 15:12:03 INFO - async*onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_maximized_persist.xul:1:1
[task 2018-04-06T15:12:03.629Z] 15:12:03 INFO - rval@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:146:17
[task 2018-04-06T15:12:03.630Z] 15:12:03 INFO - EventHandlerNonNull*this.addLoadEvent@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:171:13
[task 2018-04-06T15:12:03.630Z] 15:12:03 INFO - @chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1444:5
[task 2018-04-06T15:12:03.632Z] 15:12:03 INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-06T15:12:03.633Z] 15:12:03 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_maximized_persist.xul | height should match after restore window - got 200, expected 300
[task 2018-04-06T15:12:03.634Z] 15:12:03 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:312:5
Comment hidden (Intermittent Failures Robot) |
Comment 10•7 years ago
|
||
It seems like it should be investigated as part of 1449166, as comment 4 suggests.
Flags: needinfo?(enndeakin) → needinfo?(emilio)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 13•7 years ago
|
||
Updated 1449166 and requested info there
Comment 14•7 years ago
|
||
There is no recent activity on this bug in the last 8 days, the same situation on bug 1449166.
I've created a patch to disable this test in case we consider this a better option.
Attachment #8969182 -
Flags: review?(jmaher)
Comment 15•7 years ago
|
||
I would prefer we just skip the specific check for Linux if we want to disable it: https://searchfox.org/mozilla-central/rev/59a9a86553e9bfd9277202748ff791fd9bc0713b/toolkit/content/tests/chrome/test_maximized_persist.xul#88
Comment 16•7 years ago
|
||
Comment on attachment 8969182 [details] [diff] [review]
Skipped on linux
Review of attachment 8969182 [details] [diff] [review]:
-----------------------------------------------------------------
thanks for the patch!
Attachment #8969182 -
Flags: review?(jmaher) → review+
Comment 17•7 years ago
|
||
:xidorn, I appreciate the request, but if a robot were doing this it would have been disabled already- If there is a desire to keep this test running, please investigate the intermittent or help :emilio in bug 1449166.
Keywords: checkin-needed,
leave-open
Assignee | ||
Comment 18•7 years ago
|
||
Can we hold off landing this? I wrote a patch for the blocker bug that should fix this...
Flags: needinfo?(emilio) → needinfo?(jmaher)
Comment 19•7 years ago
|
||
yes, I didn't see any sign of work (try pushes, r?) so I assumed this was stale- we can hold off on this for a day.
Flags: needinfo?(jmaher)
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 22•7 years ago
|
||
I see a mozreview and fresh comments from the last few hours on bug 1449166, I assume this will get fixed in the next day or two.
Comment hidden (Intermittent Failures Robot) |
Comment 24•7 years ago
|
||
Waiting on a resolution from Bug 1449166.
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [stockwell disable-recommended] → [stockwell fixed:product]
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•