1447890 - Remove the range-related bits of nsISelection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove nsISelection::AddRange

MozReview-Commit-ID: 1JNLZp7tbII

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove nsISelection::RemoveRange

MozReview-Commit-ID: JXq5FYNNXPJ

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove nsISelection::GetRangeAt

MozReview-Commit-ID: GhtZwsciRL4

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove nsISelection::GetRangeCount

MozReview-Commit-ID: FypNZE0oQiW

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove nsISelection::RemoveAllRanges

MozReview-Commit-ID: EeMje9KW6An

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8961373 [details] [diff] [review]
part 5.  Remove nsISelection::RemoveAllRanges

Review of attachment 8961373 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsISelection.idl
@@ +99,5 @@
>      /**
>       * Adds all children of the specified node to the selection.
>       * @param parentNode  the parent of the children to be added to the selection.
>       */
>      void selectAllChildren(in nsIDOMNode parentNode); 

Can you clean up this whitespace while you're here?

Comment 7

[Boris Zbarsky [:bzbarsky]]

> Can you clean up this whitespace while you're here?

Done.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36a8a32f31ba
part 1.  Remove nsISelection::AddRange.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/c66a82ff97da
part 2.  Remove nsISelection::RemoveRange.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f65d3dce1a
part 3.  Remove nsISelection::GetRangeAt.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec54db5ea61
part 4.  Remove nsISelection::GetRangeCount.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/e921c3291c05
part 5.  Remove nsISelection::RemoveAllRanges.  r=mystor

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/36a8a32f31ba
https://hg.mozilla.org/mozilla-central/rev/c66a82ff97da
https://hg.mozilla.org/mozilla-central/rev/76f65d3dce1a
https://hg.mozilla.org/mozilla-central/rev/7ec54db5ea61
https://hg.mozilla.org/mozilla-central/rev/e921c3291c05