Closed Bug 1447890 Opened 2 years ago Closed 2 years ago

Remove the range-related bits of nsISelection

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(5 files)

No description provided.
Depends on: 1447121
MozReview-Commit-ID: 1JNLZp7tbII
Attachment #8961368 - Flags: review?(nika)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
MozReview-Commit-ID: JXq5FYNNXPJ
Attachment #8961369 - Flags: review?(nika)
MozReview-Commit-ID: GhtZwsciRL4
Attachment #8961370 - Flags: review?(nika)
MozReview-Commit-ID: FypNZE0oQiW
Attachment #8961371 - Flags: review?(nika)
MozReview-Commit-ID: EeMje9KW6An
Attachment #8961373 - Flags: review?(nika)
Priority: -- → P2
Attachment #8961368 - Flags: review?(nika) → review+
Attachment #8961369 - Flags: review?(nika) → review+
Attachment #8961370 - Flags: review?(nika) → review+
Attachment #8961371 - Flags: review?(nika) → review+
Comment on attachment 8961373 [details] [diff] [review]
part 5.  Remove nsISelection::RemoveAllRanges

Review of attachment 8961373 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsISelection.idl
@@ +99,5 @@
>      /**
>       * Adds all children of the specified node to the selection.
>       * @param parentNode  the parent of the children to be added to the selection.
>       */
>      void selectAllChildren(in nsIDOMNode parentNode); 

Can you clean up this whitespace while you're here?
Attachment #8961373 - Flags: review?(nika) → review+
> Can you clean up this whitespace while you're here?

Done.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36a8a32f31ba
part 1.  Remove nsISelection::AddRange.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/c66a82ff97da
part 2.  Remove nsISelection::RemoveRange.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f65d3dce1a
part 3.  Remove nsISelection::GetRangeAt.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec54db5ea61
part 4.  Remove nsISelection::GetRangeCount.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/e921c3291c05
part 5.  Remove nsISelection::RemoveAllRanges.  r=mystor
You need to log in before you can comment on or make changes to this bug.