Closed
Bug 1447890
Opened 7 years ago
Closed 7 years ago
Remove the range-related bits of nsISelection
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(5 files)
26.72 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
9.79 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
3.79 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
8.37 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
27.98 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: 1JNLZp7tbII
Attachment #8961368 -
Flags: review?(nika)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: JXq5FYNNXPJ
Attachment #8961369 -
Flags: review?(nika)
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: GhtZwsciRL4
Attachment #8961370 -
Flags: review?(nika)
Assignee | ||
Comment 4•7 years ago
|
||
MozReview-Commit-ID: FypNZE0oQiW
Attachment #8961371 -
Flags: review?(nika)
Assignee | ||
Comment 5•7 years ago
|
||
MozReview-Commit-ID: EeMje9KW6An
Attachment #8961373 -
Flags: review?(nika)
Updated•7 years ago
|
Priority: -- → P2
Updated•7 years ago
|
Attachment #8961368 -
Flags: review?(nika) → review+
Updated•7 years ago
|
Attachment #8961369 -
Flags: review?(nika) → review+
Updated•7 years ago
|
Attachment #8961370 -
Flags: review?(nika) → review+
Updated•7 years ago
|
Attachment #8961371 -
Flags: review?(nika) → review+
Comment 6•7 years ago
|
||
Comment on attachment 8961373 [details] [diff] [review]
part 5. Remove nsISelection::RemoveAllRanges
Review of attachment 8961373 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/nsISelection.idl
@@ +99,5 @@
> /**
> * Adds all children of the specified node to the selection.
> * @param parentNode the parent of the children to be added to the selection.
> */
> void selectAllChildren(in nsIDOMNode parentNode);
Can you clean up this whitespace while you're here?
Attachment #8961373 -
Flags: review?(nika) → review+
Assignee | ||
Comment 7•7 years ago
|
||
> Can you clean up this whitespace while you're here?
Done.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36a8a32f31ba
part 1. Remove nsISelection::AddRange. r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/c66a82ff97da
part 2. Remove nsISelection::RemoveRange. r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f65d3dce1a
part 3. Remove nsISelection::GetRangeAt. r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec54db5ea61
part 4. Remove nsISelection::GetRangeCount. r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/e921c3291c05
part 5. Remove nsISelection::RemoveAllRanges. r=mystor
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/36a8a32f31ba
https://hg.mozilla.org/mozilla-central/rev/c66a82ff97da
https://hg.mozilla.org/mozilla-central/rev/76f65d3dce1a
https://hg.mozilla.org/mozilla-central/rev/7ec54db5ea61
https://hg.mozilla.org/mozilla-central/rev/e921c3291c05
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•