Closed
Bug 1447956
Opened 6 years ago
Closed 6 years ago
AsyncTabSwitcher.updateDisplay should use this.tabbrowser.tabContainer instead of this.tabbrowser.tabbox.tabs
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: dao, Assigned: kirankhade7777, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
1.50 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
We should get rid of the tabs variable (it's only used once) and use this.tabbrowser.tabContainer instead: https://searchfox.org/mozilla-central/rev/c217fbde244344fedfd07b57a740c694a456dbca/browser/modules/AsyncTabSwitcher.jsm#414,416 While we're at it, we should also rename the tabPanel variable to tabpanels.
I just build firefox now. I wanted to work on this bug as my first bug. Following changes i will do in AsynchTabSwtcher.jsm file let tabs = this.tabbrowser.tabbox.tabs; //remove this line let tabPanel = this.tabbrowser.tabpanels; //rename tabPanel to tabPanels let showPanel = tabs.getRelatedElement(showTab) ; //this line will be modified to let showPanel = this.tabbrowser.tabbox.tabs.getRelatedElement(showTab) Can I proceed?
Reporter | ||
Comment 2•6 years ago
|
||
(In reply to Kiran from comment #1) > I just build firefox now. > I wanted to work on this bug as my first bug. Hi. :) > Following changes i will do in AsynchTabSwtcher.jsm file > > let tabs = this.tabbrowser.tabbox.tabs; //remove this line > let tabPanel = this.tabbrowser.tabpanels; //rename tabPanel to > tabPanels tabpanels (no camel case) rather than tabPanels, and make sure to also update the references to tabPanel. > let showPanel = tabs.getRelatedElement(showTab) ; //this line will be > modified to > let showPanel = this.tabbrowser.tabbox.tabs.getRelatedElement(showTab) Should be this.tabbrowser.tabContainer rather than this.tabbrowser.tabbox.tabs
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → kirankhade7777
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to Kiran from comment #4) > Hey how can i generate patch for same? and send it to review The simplest way is: hg diff > ~/mypatch.diff ... and then upload the diff file on this page ("Attach File" link).
-Fixed Bug 1447956.
Reporter | ||
Comment 7•6 years ago
|
||
Comment on attachment 8962178 [details] [diff] [review] mypatch.diff Looks good, thanks!
Attachment #8962178 -
Flags: review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/76eccbfed981 Use this.tabbrowser.tabContainer instead of this.tabbrowser.tabbox.tabs. r=dao
Thank you for all your help to make my first contribution easier..!! Cheers.
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/76eccbfed981
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Reporter | ||
Comment 11•6 years ago
|
||
(In reply to Kiran from comment #9) > Thank you for all your help to make my first contribution easier..!! > Cheers. You're welcome!
You need to log in
before you can comment on or make changes to this bug.
Description
•