Closed Bug 1447984 Opened 7 years ago Closed 3 years ago

[BinAST] Investigate generating a shorter BinAST parser

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: Yoric, Unassigned)

Details

The current BinAST parser is ~10kloc long. We could also generate a parser with less code (and more data) along the lines of class ShortBinASTParser { JS::Result<ParseNode*> parseSum(&Sum); JS::Result<ParseNode*> parseInterface(&Interface); JS::Result<ParseNode*> parseOption(&Option); JS::Result<ParseNode*> parseEnum(&Enum); }; Where: * an instance of `Sum` is a mapping from BinKind => Interface (plus an optional function pointer for verification and/or building); * an instance of `Sum` is a BinKind and a list of field types, plus a function pointer for verification and building; * ... This would produce a smaller binary, which might (or might not) fit better in the cache.
Priority: -- → P3
Summary: Investigate generating a shorter BinAST parser → [BinAST] Investigate generating a shorter BinAST parser
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.