1448010 - Remove unused nsSAXXML idl methods

Status: RESOLVED FIXED

(Core :: XML, enhancement, P2)

Description

[Tom Ritter [:tjr]]

We don't use them, we can remove them.

Comment 1

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=33a8e0e2ee356af24cbf1fbece463d8f67e93e0b&selectedJob=169666320

I pinged #maildev, got a response, so I think we're good.

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1448010 Remove unused nsSAXXML IDL methods

Review commit: https://reviewboard.mozilla.org/r/230214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230214/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8961455 [details]
Bug 1448010 Remove unused nsSAXXML IDL methods

https://reviewboard.mozilla.org/r/230214/#review235838

I'm a bit confused by this patch, so going to clear review for now.

Firstly, I see callsites for this in the feedprocessor. If those have no non-test uses, then we can remove those too, and their respective IDL definitions (and the tests that do currently exercise them, if that's not a reflection of what actually happens when loading feeds / live bookmarks).

Orthogonally, if we remove the IDL definitions, then presumably we should remove the implementation from the sax parser as well?

Comment 4

[:Gijs (he/him)]

Note that the trypush doesn't run tests, only builds, so you don't see errors from the JS consumers if they *are* exercised (ie the JS consumers or lack thereof won't affect the build result).

Comment 5

[Tom Ritter [:tjr]]

Comment on attachment 8961455 [details]
Bug 1448010 Remove unused nsSAXXML IDL methods

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230214/diff/1-2/

Comment 6

[:Gijs (he/him)]

Comment on attachment 8961455 [details]
Bug 1448010 Remove unused nsSAXXML IDL methods

https://reviewboard.mozilla.org/r/230214/#review236590

Assuming frontend tests (mochitest) pass, lgtm, thanks!

::: parser/xml/test/unit/test_parser.js:97
(Diff revision 2)
> +  
> +  saxReader.parseAsync(null, uri);
> +  saxReader.onStartRequest(channel, uri);
> +  

Nit: trailing whitespace

Comment 7

[Tom Ritter [:tjr]]

Comment on attachment 8961455 [details]
Bug 1448010 Remove unused nsSAXXML IDL methods

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230214/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9de00749ad9
Remove unused nsSAXXML IDL methods r=Gijs

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b9de00749ad9