Closed
Bug 1448010
Opened 6 years ago
Closed 6 years ago
Remove unused nsSAXXML idl methods
Categories
(Core :: XML, enhancement, P2)
Core
XML
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(1 file)
We don't use them, we can remove them.
Assignee | ||
Comment 1•6 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=33a8e0e2ee356af24cbf1fbece463d8f67e93e0b&selectedJob=169666320 I pinged #maildev, got a response, so I think we're good.
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8961455 [details] Bug 1448010 Remove unused nsSAXXML IDL methods https://reviewboard.mozilla.org/r/230214/#review235838 I'm a bit confused by this patch, so going to clear review for now. Firstly, I see callsites for this in the feedprocessor. If those have no non-test uses, then we can remove those too, and their respective IDL definitions (and the tests that do currently exercise them, if that's not a reflection of what actually happens when loading feeds / live bookmarks). Orthogonally, if we remove the IDL definitions, then presumably we should remove the implementation from the sax parser as well?
Attachment #8961455 -
Flags: review?(gijskruitbosch+bugs)
Comment 4•6 years ago
|
||
Note that the trypush doesn't run tests, only builds, so you don't see errors from the JS consumers if they *are* exercised (ie the JS consumers or lack thereof won't affect the build result).
Updated•6 years ago
|
Priority: -- → P2
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8961455 [details] Bug 1448010 Remove unused nsSAXXML IDL methods https://reviewboard.mozilla.org/r/230214/#review236590 Assuming frontend tests (mochitest) pass, lgtm, thanks! ::: parser/xml/test/unit/test_parser.js:97 (Diff revision 2) > + > + saxReader.parseAsync(null, uri); > + saxReader.onStartRequest(channel, uri); > + Nit: trailing whitespace
Attachment #8961455 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b9de00749ad9 Remove unused nsSAXXML IDL methods r=Gijs
Keywords: checkin-needed
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b9de00749ad9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•