1448068 - Update Fluent migrations in mozilla-central to run against gecko-strings

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Francesco Lodolo [:flod]]

Currently all migrations are set up to run against mozilla-central, we should run them against gecko-strings structure.

That's the only way to avoid losing strings that are currently in beta or release, but not in central. We already have that case for strings in the General pane, replaced in 61 by Activity Stream.

This bug will also:
* Fix a migration error introduced in bug 1419547.
* Remove a temporary string that we left in preferences.ftl, to avoid removing it when running migrations.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1448068 - Update Fluent migrations in mozilla-central to run against gecko-strings

Also remove temporary string from preferences.ftl (search-input). This was added
to avoid removing the string when running migrations against mozilla-central

Review commit: https://reviewboard.mozilla.org/r/230252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230252/

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #0)
> * Remove a temporary string that we left in preferences.ftl, to avoid
> removing it when running migrations.

search-input is only used in 60, but cross-channel logic for gecko-strings will take care of that
https://dxr.mozilla.org/mozilla-beta/rev/e8887d50d037e3fc4c74142e95ef529b1e6025e2/browser/locales/en-US/browser/preferences/preferences.ftl#25

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8961480 [details]
Bug 1448068 - Update Fluent migrations in mozilla-central to run against gecko-strings

https://reviewboard.mozilla.org/r/230252/#review235860

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/307521ba5e6a
Update Fluent migrations in mozilla-central to run against gecko-strings r=Pike

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/307521ba5e6a