1448133 - Add a Nightly-only run-time pref to run tab throbber animation at 30fps

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

+++ This bug was initially created as a clone of Bug #1447153 +++

This is to make it easier to diagnose things like bug 1406414, bug 1439511 and bug 1428704.

This is Nightly only because this is only for testing. This configuration should never reach release.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1448133 - Add a Nightly-only preference to set the tab throbber to animate at 30fps.

Review commit: https://reviewboard.mozilla.org/r/230314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230314/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8961526 [details]
Bug 1448133 - Add a Nightly-only preference to set the tab throbber to animate at 30fps.

https://reviewboard.mozilla.org/r/230314/#review236302

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bc1183fb32e
Add a Nightly-only preference to set the tab throbber to animate at 30fps. r=jaws

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7bc1183fb32e

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Setting step function is pretty useless for compositor animations.  We do skip restyling for such animations on the main-thread[1], but we don't do it on the compositor.

[1] https://hg.mozilla.org/mozilla-central/file/7ff499dfcd51/dom/animation/KeyframeEffectReadOnly.cpp#l132

Comment 6

[Mike Conley (:mconley) (:⚙️)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #5)
> Setting step function is pretty useless for compositor animations.  We do
> skip restyling for such animations on the main-thread[1], but we don't do it
> on the compositor.

That's super disappointing. Is there a way we could make the compositor smarter here?

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Filed bug 1454324 for that.