1448178 - Client should be able to catch unknownError packets from actors

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

See bug 1443550. According to :jryans:

> when we call the actor 
> https://searchfox.org/mozilla-central/source/devtools/server/main.js#1780
> and an error occurs, we don't include the actor ID in the packet. 
> if we did, the client could react.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1448178 - include actorId in unknown error packet from DevTools server;

Review commit: https://reviewboard.mozilla.org/r/230458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230458/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8961595 [details]
Bug 1448178 - include actorId in unknown error packet from DevTools server;

https://reviewboard.mozilla.org/r/230458/#review236298

Thanks for working on this!  It looks good to me. :)

I am actually quite surprised this has never come up before now... :S It seems like a very long standing bug as far as I can tell...

::: commit-message-4598a:1
(Diff revision 1)
> +Bug 1448178 - include actorId in unknown error packet from DevTools server;r=jryans

It might be nice to also mention why this is helpful in the commit message.

::: devtools/server/main.js:1630
(Diff revision 1)
>        }
>      }
>      return null;
>    },
>  
> -  _unknownError(prefix, error) {
> +  _unknownError(prefix, error, from) {

Many of the actor related functions take `from` (the actor ID) as the first arg, so it might be nice to do the same here...  Not really a big deal though, feel free to disagree.

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8961595 [details]
Bug 1448178 - include actorId in unknown error packet from DevTools server;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230458/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7f56a5f56f7
include actorId in unknown error packet from DevTools server;r=jryans

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/a7f56a5f56f7