Closed
Bug 1448208
Opened 7 years ago
Closed 7 years ago
Overflow check in nsWindowWatcher relies on undefined behavior
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
2.24 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
clang-cl builds fail the mochitest added in bug 978847 because the compiler assumes this signed integer operation can't overflow: https://searchfox.org/mozilla-central/rev/c217fbde244344fedfd07b57a740c694a456dbca/toolkit/components/windowwatcher/nsWindowWatcher.cpp#2428
Assignee: nobody → dmajor
Attachment #8961622 -
Flags: review?(nfroyd)
|
||
Updated•7 years ago
|
Priority: -- → P2
This should fix the ccov failure as well: https://searchfox.org/mozilla-central/source/toolkit/components/windowcreator/test/mochitest.ini#12
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8961622 [details] [diff] [review]
checkedInt
Review of attachment 8961622 [details] [diff] [review]:
-----------------------------------------------------------------
More CheckedInt usage is always a good thing.
Attachment #8961622 -
Flags: review?(nfroyd) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4db836a8d12b
Use CheckedInt for overflow check in nsWindowWatcher::SizeOpenedWindow. r=froydnj
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•