1448220 - Convert VarCache prefs used by the network predictor service to use StaticPrefs

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Nicholas Nethercote [inactive]]

See bug 1448219 for details.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1448220 - Convert all network predictor VarCache prefs to the new StaticPrefList form.

Review commit: https://reviewboard.mozilla.org/r/230510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230510/

Comment 2

[u408661]

Comment on attachment 8961638 [details]
Bug 1448220 - Convert all network predictor VarCache prefs to the new StaticPrefList form.

https://reviewboard.mozilla.org/r/230510/#review236630

Well, I'm not a big fan of how this makes the code read (the general approach, IMO, hurts dev ergonomics), but that ship has sailed. Given all that, this looks as reasonable as can be expected.

Comment 3

[Nicholas Nethercote [inactive]]

> Well, I'm not a big fan of how this makes the code read (the general
> approach, IMO, hurts dev ergonomics), but that ship has sailed.

What are your objections?

Comment 4

[u408661]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> What are your objections?

Nothing that hasn't been stated over in bug 1436655 (kills rebuild times when adding a pref, less succinct code), but also over there those have been weighed & deemed acceptable tradeoffs. That's fine, and there certainly are benefits to this approach, so I wasn't really doing anything more than venting. Apologies for taking it out on you and your patch :)

Comment 5

[Nicholas Nethercote [inactive]]

The rebuild time is regrettable. As for succinctness: this reduces the number of lines of code. Perhaps you are referring to the length of the getter name?

Comment 6

[u408661]

(In reply to Nicholas Nethercote [:njn] from comment #5)
> The rebuild time is regrettable. As for succinctness: this reduces the
> number of lines of code. Perhaps you are referring to the length of the
> getter name?

Yep :)

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7ebb62677a6e8ecff0d86953c4c36c27f78a35c
Bug 1448220 - Convert all network predictor VarCache prefs to the new StaticPrefList form. r=hurley

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a7ebb62677a6