1448330 - Make nsIURI.clone a private method

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

Since we don't need to clone URIs to prevent them from being changed, the clone method is a bit redundant. It should only be used by the mutators, so I propose that we make it private, and remove all other calls presently in the code.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1448330 - Make nsIURI.clone a private method

Review commit: https://reviewboard.mozilla.org/r/250944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250944/

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8985327 [details]
Bug 1448330 - Make nsIURI.clone a private method

https://reviewboard.mozilla.org/r/250944/#review258042

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/110e4b10e2ea
Make nsIURI.clone a private method r=mayhemer

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/110e4b10e2ea

Comment 5

[Jorg K (CEST = GMT+2)]

That busted TB a bit :-( - What about cloneIgnoringRef() and cloneWithNewRef()?

Comment 6

[Jorg K (CEST = GMT+2)]

Stuff like:
mailnews/addrbook/src/nsAddbookUrl.cpp
194 rv = m_baseURL->Clone(getter_AddRefs(clone->m_baseURL));
mailnews/compose/src/nsSmtpUrl.cpp
536 rv = m_baseURL->Clone(getter_AddRefs(clone->m_baseURL));
becomes impossible since the base URL doesn't offer the method any more :-(

Comment 7

[Valentin Gosu [:valentin] (he/him)]

(In reply to Jorg K (GMT+2) from comment #5)
> That busted TB a bit :-( - What about cloneIgnoringRef() and
> cloneWithNewRef()?

I'll remove them in a followup.

(In reply to Jorg K (GMT+2) from comment #6)
> Stuff like:
> mailnews/addrbook/src/nsAddbookUrl.cpp
> 194 rv = m_baseURL->Clone(getter_AddRefs(clone->m_baseURL));
> mailnews/compose/src/nsSmtpUrl.cpp
> 536 rv = m_baseURL->Clone(getter_AddRefs(clone->m_baseURL));
> becomes impossible since the base URL doesn't offer the method any more :-(

Cloning is unnecessary now (assuming nsIURI implementations are threadsafe/immutable) and you just need to copy the RefPtr.
Otherwise, mutate + finalize achieves the same as clone (as you already noticed in bug 1470046)