Closed Bug 1448349 Opened 4 years ago Closed 2 years ago
configure fails when git for Windows is in PATH ahead of Mozilla
Build's msys (/usr/bin/grep: nul: No such file or directory)
47 bytes, text/x-phabricator-request
|Details | Review|
Fresh build on windows 10, latest mozillaBuild, I have hit this twice in a row following the installation instructions @ https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites https://gist.github.com/daleharvey/f2d48c0b7b371a22bcbb3469925ca743 is the full log: 0:08.67 checking for autoconf... C:/mozilla-build/msys/local/bin/autoconf-2.13 0:08.67 Refreshing c:/Users/daleharvey/src/gecko-dev/old-configure with C:/mozilla-build/msys/local/bin/autoconf-2.13 0:08.73 /usr/bin/sed: -e expression #1, char 10: unterminated `s' command 0:08.85 autoconf: Undefined macros: 0:08.91 /usr/bin/grep: nul: No such file or directory Seemm the most relevant for the error
So the error here was, this is a git clone, the mozillabuild shell could not see git (although the command prompt could) and failed so I added the git path to my bash_profile, but adding it to the start of the path sonds like its msys tools were used instead of the supported versions causing problems, If I added the git path to the end of my $PATH it looks to be working properly
This sounds like something we could potentially detect in moz.configure. I think the specific error here is probably that the shell we wound up using to execute autoconf was from git. If we're on Windows we could check that the shell in PATH is from MozillaBuild, and error if it's not.
Summary: /usr/bin/grep: nul: No such file or directory → configure fails when git for Windows is in PATH ahead of MozillaBuild's msys (/usr/bin/grep: nul: No such file or directory)
FWIW `nul` is a reserved filename on Windows. Any attempts to access files of that name will fail. Git doesn't recognize these reserved filenames and you'll get run-time failures if a file with a reserved filename is in the repo. Mercurial aborts more gracefully. Not sure where this `nul` file is coming from though.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/7dcc2fa474a8 Warn about autoconf $PATH problems on win32 r=firefox-build-system-reviewers,chmanchester
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/55d7f113d4ae Warn about autoconf $PATH problems on win32 r=firefox-build-system-reviewers,chmanchester
You need to log in before you can comment on or make changes to this bug.