Closed
Bug 1448436
Opened 7 years ago
Closed 7 years ago
Remove unneeded workaround for older MSVC versions in CounterStyleManager.cpp
Categories
(Core :: CSS Parsing and Computation, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
|
1.82 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
Bug 1393189 added a workaround for older MSVC compilers <2017 to avoid startup crashes. Now that we require 2017 as the minimum version, we can remove it and simplify the code.
|
Assignee | |
Comment 1•7 years ago
|
||
This just reverts the code back to what was originally landed in the bug before being backed out for bustage. Green on Try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7cc7e183898b71d4d0abb93555efe6aa6815a41
Attachment #8961924 -
Flags: review?(xidorn+moz)
|
||
Updated•7 years ago
|
Attachment #8961924 -
Flags: review?(xidorn+moz) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e81fdb3b711f Remove an unneeded workaround for MSVC <2017 from CounterStyleManager.cpp. r=xidorn
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e81fdb3b711f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•