1448461 - libaom needs a MingGW x64 config

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Otherwise we get errors like

> /builds/worker/workspace/build/src/third_party/aom/aom_ports/x86.h:121:1: error: multiple storage classes in declaration specifiers

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1448461 Give libaom a x64 MinGW config

Review commit: https://reviewboard.mozilla.org/r/230800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230800/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

https://reviewboard.mozilla.org/r/230800/#review236854

I am not the right person to review this. Based on looking at the review log, probably kinetik or froydnj are. I'll pass the review to kinetik, and he can consider pass onto froydnj if he feels appropriate.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

https://reviewboard.mozilla.org/r/230800/#review237260

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4ffee583176
Give libaom a x64 MinGW config r=kinetik

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d4ffee583176

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

mingw build fix, approved for 60.1esr

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/abc0f9a278d6