Closed Bug 1448461 Opened 2 years ago Closed 2 years ago

libaom needs a MingGW x64 config

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

(Whiteboard: [tor])

Attachments

(1 file)

Otherwise we get errors like

> /builds/worker/workspace/build/src/third_party/aom/aom_ports/x86.h:121:1: error: multiple storage classes in declaration specifiers
Component: Audio/Video → Audio/Video: Playback
Attachment #8961955 - Flags: review?(cpearce)
Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

https://reviewboard.mozilla.org/r/230800/#review236854

I am not the right person to review this. Based on looking at the review log, probably kinetik or froydnj are. I'll pass the review to kinetik, and he can consider pass onto froydnj if he feels appropriate.
Attachment #8961955 - Flags: review?(cpearce) → review?(kinetik)
Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

https://reviewboard.mozilla.org/r/230800/#review237260
Attachment #8961955 - Flags: review?(kinetik) → review+
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4ffee583176
Give libaom a x64 MinGW config r=kinetik
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d4ffee583176
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8961955 - Flags: approval-mozilla-esr60?
Comment on attachment 8961955 [details]
Bug 1448461 Give libaom a x64 MinGW config

mingw build fix, approved for 60.1esr
Attachment #8961955 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.