Closed
Bug 1448472
Opened 7 years ago
Closed 7 years ago
Remove unneeded C5037 warning suppression in xpcom/string/moz.build
Categories
(Core :: XPCOM, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
Bug 1397942 added a workaround to xpcom/string/moz.build to avoid triggering warning C5037 in buggy versions of MSVC 2017. This issue has since been fixed upstream and our minimum supported version of 15.6 works fine with the suppression removed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ef733c5ee2085d525281400f04f4949303efbed
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8961936 -
Flags: review?(xidorn+moz)
|
||
Updated•7 years ago
|
Attachment #8961936 -
Flags: review?(xidorn+moz) → review+
|
|
||
Comment 2•7 years ago
|
||
Thanks for removing these.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0832da6741d
Remove a C5037 warning suppression xpcom/string/moz.build that is no longer needed. r=xidorn
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•