1448533 - [test] format=tbpl doesn't work for xpcshell tests

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

I put:

  [test]
  format=tbpl

In my ~/.mozbuild/machrc.  That works for mochitest, but not for xpcshell tests: those are still getting the mach coloring.

Comment 1

[Boris Zbarsky [:bzbarsky]]

In particular, I _do_ get different behavior with "mach xpcshell-test --log-tpbl=-" but not with that machrc bit.

Comment 2

[Andrew Halberstadt [:ahal]]

Yes, |mach xpcshell-test| should honour this config as well. No

Comment 3

[Andrew Halberstadt [:ahal]]

Was going to say:
Note, if you run |mach test <path/to/xpcshell/test>|, the mach config would get picked up.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1448533 - Honour the 'test.format' machrc config setting in |mach xpcshell-test|,

Since |mach xpcshell-test| was already defaulting to the 'mach' format, this will be a no-op
for most people. For anyone who had:

[test]
format=tbpl

in their machrc file, this will start working for xpcshell tests.

Review commit: https://reviewboard.mozilla.org/r/231240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231240/

Comment 5

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Comment on attachment 8963254 [details]
Bug 1448533 - Honour the 'test.format' machrc config setting in |mach xpcshell-test|,

https://reviewboard.mozilla.org/r/231240/#review237674

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe56904f1c56
Honour the 'test.format' machrc config setting in |mach xpcshell-test|, r=gbrown

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fe56904f1c56