Closed
Bug 1448575
Opened 8 years ago
Closed 8 years ago
Use AssignLiteral/AssignASCII for short ASCII constant strings in nsAccessibilityService
Categories
(Core :: Disability Access APIs, enhancement)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
Avoid useless use of the SIMD-accelerated CopyUTF8toUTF16 when the string is shorter than 16 ASCII characters.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8962072 -
Flags: review?(surkov.alexander)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962072 [details]
Bug 1448575 - Use AssignLiteral/AssignASCII for short ASCII constant strings in nsAccessibilityService.
https://reviewboard.mozilla.org/r/230908/#review236688
I wish the difference between those methods was documented somewhere, now CopyUTF8ToUTF16 doesn't seem documented at all (https://dxr.mozilla.org/mozilla-central/source/xpcom/string/nsReadableUtils.h#53)
Attachment #8962072 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
I'll write some docs. Thanks.
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7b8cacf509d
Use AssignLiteral/AssignASCII for short ASCII constant strings in nsAccessibilityService. r=surkov
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•