1448637 - Crash in shutdownhang | static bool mozilla::SpinEventLoopUntil<T>

Status: RESOLVED DUPLICATE of bug 1411908

(Core :: Storage: Quota Manager, defect, P2)

Description

[Julian Seward [:jseward]]

This bug was filed from the Socorro interface and is
report bp-a9e71c13-73dd-4d48-82b2-8281f0180324.
=============================================================

This is topcrash #14 in the Windows nightly 20180322100349, with
7 crashes from 5 different installations.

Top 10 frames of crashing thread:

0 ntdll.dll NtWaitForAlertByThreadId 
1 ntdll.dll RtlSleepConditionVariableCS 
2 kernelbase.dll SleepConditionVariableCS 
3 mozglue.dll mozilla::detail::ConditionVariableImpl::wait mozglue/misc/ConditionVariable_windows.cpp:58
4 xul.dll mozilla::CondVar::Wait xpcom/threads/CondVar.h:68
5 xul.dll mozilla::ThreadEventQueue<mozilla::PrioritizedEventQueue<mozilla::EventQueue> >::GetEvent xpcom/threads/ThreadEventQueue.cpp:155
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:999
7 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:517
8 xul.dll static bool mozilla::SpinEventLoopUntil<1, <lambda_817ce6743c2a9e377cddc81567325999> > xpcom/threads/nsThreadUtils.h:323
9 xul.dll mozilla::dom::quota::QuotaManager::ShutdownObserver::Observe dom/quota/ActorsParent.cpp:2911

=============================================================

Comment 1

[Nathan Froyd [:froydnj]]

OK, so the main thread is hanging during QuotaManager::ShutdownObserver::Observe.  The IPDL Background thread (thread 15) is waiting on QuotaManager::Shutdown:

0 	ntdll.dll 	NtWaitForAlertByThreadId 	
1 	ntdll.dll 	RtlSleepConditionVariableCS 	
2 	KERNELBASE.dll 	SleepConditionVariableCS 	
3 	mozglue.dll 	mozilla::detail::ConditionVariableImpl::wait(mozilla::detail::MutexImpl&) 	mozglue/misc/ConditionVariable_windows.cpp:58
4 	xul.dll 	mozilla::ThreadEventQueue<mozilla::EventQueue>::GetEvent(bool, mozilla::EventPriority*) 	xpcom/threads/ThreadEventQueue.cpp:155
5 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp:999
6 	xul.dll 	NS_ProcessNextEvent(nsIThread*, bool) 	xpcom/threads/nsThreadUtils.cpp:517
7 	xul.dll 	static bool mozilla::SpinEventLoopUntil<1, <lambda_6cde64f79e038724560623f7e881f1b4> >(class mozilla::dom::indexedDB::`anonymous-namespace'::ConnectionPool::Shutdown::__l18::<lambda_6cde64f79e038724560623f7e881f1b4>*, class nsIThread*) 	xpcom/threads/nsThreadUtils.h:323
8 	xul.dll 	static void mozilla::dom::indexedDB::`anonymous namespace'::ConnectionPool::Shutdown() 	dom/indexedDB/ActorsParent.cpp:12265
9 	xul.dll 	static void mozilla::dom::indexedDB::`anonymous namespace'::QuotaClient::ShutdownWorkThreads() 	dom/indexedDB/ActorsParent.cpp:17906
10 	xul.dll 	mozilla::dom::quota::QuotaManager::Shutdown() 	dom/quota/ActorsParent.cpp:3686
11 	xul.dll 	mozilla::dom::quota::QuotaManager::ShutdownRunnable::Run() 	dom/quota/ActorsParent.cpp:2862

I guess we're waiting for all the active DB connections to shutdown?  Perhaps we already have a preexisting bug for this sort of thing?  ni? to baku for this sort of stuff.

Comment 2

[Andrea Marchesini [:baku]]

Yes, we have bug 1435958 for this.

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

This is just a dupe of bug 1411908. Somehow the type changed in the signature which broke the prefix stuff and made it not match.

This is: [@ shutdownhang | static bool mozilla::SpinEventLoopUntil<T> ]

before it had:

[@ shutdownhang | mozilla::SpinEventLoopUntil<T> | mozilla::dom::quota::QuotaManager::ShutdownObserver::Observe ]

I'm not sure what prefix regex would match without the static bool that doesn't match the static bool....

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

I'll file a bug against Socorro blocking this bug. I don't see why it isn't matching. (The signature would still change, but it would at least show the QuotaManager stuff.)