Closed
Bug 1448667
Opened 7 years ago
Closed 7 years ago
No smoothing in SVG mask as circle
Categories
(Core :: Graphics, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox59 | --- | wontfix |
| firefox60 | --- | wontfix |
| firefox61 | --- | fixed |
People
(Reporter: evangelinerei, Assigned: lsalzman)
References
Details
(Keywords: regression, Whiteboard: [gfx-noted])
Attachments
(2 files)
|
10.24 KB,
image/png
|
Details | |
|
4.21 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
bug.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180315233128
Steps to reproduce:
Simple SVG mask as <circle>, or similar <path> displays as NOT smoothed
Check this code https://jsfiddle.net/2b4tgpq5/6/
Actual results:
Antialiasing with mask as circle or similar path dissapears
Expected results:
Should be some antialiasing. Check attached image to see how SHOULD BE
|
||
Comment 1•7 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6b534147049e9a4afaa3320712d824dc9563ac67&tochange=7fb451a4d22c87e7de74be4c169c85601bdb938e
Regressed by: Bug 1359527
Blocks: 1359527
Status: UNCONFIRMED → NEW
status-firefox59:
--- → wontfix
status-firefox60:
--- → wontfix
status-firefox61:
--- → affected
status-firefox-esr52:
--- → unaffected
Component: Untriaged → Graphics
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
|
Assignee | |
Updated•7 years ago
|
OS: Unspecified → Windows
Priority: -- → P3
Whiteboard: [gfx-noted]
|
|
Assignee | |
Comment 2•7 years ago
|
||
Apparently PushLayer() is not liking the intermediate image generated by LuminanceToAlpha. The only workaround that seems to help is to use the ColorMatrix with specifically STRAIGHT alpha mode (PREMULTIPLIED alpha mode reproduces the bug).
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8964653 [details] [diff] [review]
use ColorMatrix effect instead of LuminanceToAlpha effect for DrawTargetD2D1::IntoLuminanceSourc
Review of attachment 8964653 [details] [diff] [review]:
-----------------------------------------------------------------
Bas should look at this instead.
Attachment #8964653 -
Flags: review?(jmuizelaar) → review?(bas)
|
||
Updated•7 years ago
|
Attachment #8964653 -
Flags: review?(bas) → review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/458c07cbe94b
use ColorMatrix effect instead of LuminanceToAlpha effect for DrawTargetD2D1::IntoLuminanceSource. r=bas
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•6 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•