1448681 - Bugmail Message-ID header format changed without changing In-Reply-To/References, breaking threading

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Email Notifications, defect, P1)

Description

[Phil Ringnalda (:philor)]

The bugmail for bug 1448608 comment 0 has the header "Message-ID: <[e-mail]>" but the bugmail for bug 1448608 comment 1 has "In-Reply-To: <[e-mail]/>" and "References: <[e-mail]/>" (which is the format that Message-ID had before 2018-03-24) so Thunderbird no longer knows how to sort the first bugmail into the same thread as the rest, since it thinks the second and subsequent ones are replies to an email it never saw.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

"Amazon SES overrides any Message-ID header you provide.)"

So this effectively means people will not have email threading and that a major bugzilla feature cannot work with SES.

Comment 2

[Chris Kolosiwsky [:ckolos] (ckolos has left the building)]

can something similar to this be done?  https://meta.discourse.org/t/email-in-replies-thread-wrongly/59365/5?u=leomca

Comment 3

[Mark Côté [:mcote]]

FYI GMail threading appears to still work (which I realize does its own thing, but wanted to note that anyway).

Comment 4

[:glob ✱]

Attachment: pr

threading is only broken for the "new bug" emails; adding a `references` header that references itself seems to fix the issue (on thunderbird/postbox at least).

Comment 5

[Mike Hommey [:glandium]]

FWIW, the attached patch is likely to make bug opening bugmail appearing as answers to unexisting messages in e.g. mutt.

Comment 6

[:glob ✱]

(In reply to Mike Hommey [:glandium] from comment #5)
> FWIW, the attached patch is likely to make bug opening bugmail appearing as
> answers to unexisting messages in e.g. mutt.

sorry, i'm not sure i understand what you're saying.

unfortunately we're limited in what we can do.  the threading headers are built around message-id, which is being overwritten by ses after we submit it for delivery.  (ab)using references in this way is probably the best we can do without significantly more work.

Comment 7

[Mike Hommey [:glandium]]

AFAICT, this is not fixed yet.

Comment 8

[:glob ✱]

we close bugs as FIXED when the code lands; it hasn't been deployed yet (this should happen soon).

Comment 10

[Mike Hommey [:glandium]]

(In reply to Byron Jones ‹:glob› from comment #8)
> we close bugs as FIXED when the code lands; it hasn't been deployed yet
> (this should happen soon).

a week later, that apparently still hasn't happened.

Comment 12

[:glob ✱]

dylan - what's happening the production deploy for this?

Comment 13

[Dylan Hardison [:dylan] (he/him)]

it was deployed last week, on Thursday.