1448693 - DumpJSStack() output not visible on Android

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1448693 - Make DumpJSStack() output appear somewhere visible on Android.

... by writing it to stderr, which in turn gets redirected to the logcat.

Review commit: https://reviewboard.mozilla.org/r/231030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231030/

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8962188 [details]
Bug 1448693 - Make DumpJSStack() output appear somewhere visible on Android.

https://reviewboard.mozilla.org/r/231030/#review236726

r=me with my question addressed about the best way to dump to logcat.

::: js/xpconnect/src/XPCDebug.cpp:35
(Diff revision 1)
>    if (IsDebuggerPresent()) {
>      OutputDebugStringA(buffer);
>    }
>  #endif
> +#ifdef ANDROID
> +  printf_stderr("%s", buffer);

nsGlobalWindowInner::Dump uses `__android_log_write(ANDROID_LOG_INFO, "GeckoDump", [buffer]);` as well as printf. Would it make sense to use the same output method here as well?

Comment 3

[Jan Henning [:JanH]]

Comment on attachment 8962188 [details]
Bug 1448693 - Make DumpJSStack() output appear somewhere visible on Android.

https://reviewboard.mozilla.org/r/231030/#review236726

> nsGlobalWindowInner::Dump uses `__android_log_write(ANDROID_LOG_INFO, "GeckoDump", [buffer]);` as well as printf. Would it make sense to use the same output method here as well?

Are you referring to using `__android_log_write` directly vs. using it indirectly via `printf_stderr`, or whether to use stderr/logcat *in addition* or *instead of* printf on Android (or both)?

Comment 4

[Jan Henning [:JanH]]

Comment on attachment 8962188 [details]
Bug 1448693 - Make DumpJSStack() output appear somewhere visible on Android.

https://reviewboard.mozilla.org/r/231030/#review236726

> Are you referring to using `__android_log_write` directly vs. using it indirectly via `printf_stderr`, or whether to use stderr/logcat *in addition* or *instead of* printf on Android (or both)?

Although thinking some more about it, I guess I should do both - use `__android_log_write` directly with a custom Logtag (GeckoJS ?) and write to the logcat *in addition* to stdout, so if anybody wants to redirect the latter to somewhere else, they can still get the output as well.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Jan Henning [:JanH] from comment #4)
> Although thinking some more about it, I guess I should do both - use
> `__android_log_write` directly with a custom Logtag (GeckoJS ?) and write to
> the logcat *in addition* to stdout, so if anybody wants to redirect the
> latter to somewhere else, they can still get the output as well.

Yeah -- more generally it seems like the two `dump`s should mirror each other so that they behave similarly.

Comment 6

[Jan Henning [:JanH]]

Comment on attachment 8962188 [details]
Bug 1448693 - Make DumpJSStack() output appear somewhere visible on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231030/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a18353aa563c
Make DumpJSStack() output appear somewhere visible on Android. r=mrbkap

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a18353aa563c