1448721 - hang on launch when sync and master password set

Status: RESOLVED DUPLICATE of bug 1295122

(Firefox :: Sync, defect)

Description

[Paul Nguyen, OMV]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce:

After upgrade to current developer version 60.0b6 on Windows 10 v1709, I would get a hang-on-launch (Stopped responding) with the main window and the Master Password prompt showing.

I followed advice in reply to my comment https://bugzilla.mozilla.org/show_bug.cgi?id=1445280#c4 to try solutions to bug 1295122 concerning a sync error (the Browser Log started to look like this problem). In my Roaming profile were all three files: logins.json, key3.db, key4.db, so I deleted all three and launched FF again.

Clean start, pulled up my history in about:home, searching and navigating from address bar worked: all fine.

Then I went to Preferences, ticked the box to set a Master Password, and signed into Sync. I reset the about:config preference to trigger a passwords sync, which happened fine (Saved Logins showed them).




Actual results:

But when I closed and re-launched FF, I got the same hang on launch with main window and Master Password prompt showing.

Repeating the procedure to delete logins, key3, key4 and starting up without setting a Master Password, the launch is stable time after time.


Expected results:

Clean start with about:home populated with my history/top sites. Passwords synced and master password set. Everything else functional (address bar suggests from all local sources and navigates with Enter keypress)

Comment 1

[Adrian Florinescu [:aflorinescu]]

I've tested using 60.0b7 20180326164103 on Windows 7 and Windows 10 and I haven't experienced any issues similar with what you describe above.

Paul, could you check what the behavior is on Nightly 61 (https://download.mozilla.org/?product=firefox-nightly-stub&os=win&lang=en-US). 

:markh, could this bug also something related to 1295122?

Comment 2

[Paul Nguyen, OMV]

Thanks for the response! Trying Nightly 61 as requested. Basically seeing the same symptoms, although on repeated starts, I'm not getting a full application hang with the master password prompt showing.

I did upgrade to 60.0b7 but did not play with the config there. I have been running ff without saving passwords or having master password set at all (unchecked those two boxes in security preferences).

Here's my action sequence with nightly and what happened.
LAUNCHED ff nightly 61.0a1 20180330 64bit
looks like it loaded the same profile I was running with dev edition/aurora channel.
enabled password saving and master password
sync failure triggered a log
RESTART ff nightly
top sites, etc on about:home were all blank
first sync attempt required log in to sync
log in sent me an email with clickable verification
manual sync did not trigger errors.
about:home still blank.
about:preferences > Search does not open the config page
history and bookmarks are populated, but address bar doesn't see them
SECOND RESTART same nightly
all the same symptoms, and sync wants to reconnect again.

I'm attaching the sync logs since I launched Nightly. And also the browser console output from the first RESTART section above.

Comment 3

[Paul Nguyen, OMV]

Attachment: Browser console - nightly test

Comment 4

[Paul Nguyen, OMV]

Attachment: sync logs 20180330

Comment 5

[Paul Nguyen, OMV]

Another note, :markh did suggest it was a bug 1295122 issue. I previously tried the tip to remove key3.db and the other files, and it comes right back. I don't know if it was expected to not be installed in a fresh profile. The default profile has a key3.db of 16,384 bytes. Current user profile has key3.db of same length.

default roaming profile key3.db has SHA1 checksum:
59411a92fab47a888cac1d51b6e5ea09d0fc481c *key3.db

current user roaming profile key3.db has SHA1 checksum:
fdbd549a30c53f36c899fbd9d23afb0453484fca *key3.db

I don't know if the thing is sensitive, but I can post if it would help.

Comment 6

[Adrian Florinescu [:aflorinescu]]

What I can say from previous experiences with sync is that most likely your sync account might already contain some "weird" data in it, so when you attempt to sync any new profile on any version you keep stumbling over the same issue. I'm not sure particularly sure how easy is to debug this scenario, if indeed this is the one but maybe :markh might have more insight on this matter.

What I would like to verify is the validity of my above assumption. Therefore, could you please assist with the following test?

1. Create a new profile (do not log into sync/master password)
2. Create a new sync account.
3. Use the the new profile and the new sync account to try to reproduce the issue. 

Please note that using new profile and new sync account should isolate the test environment from your original profile, so it would be advisable to try not to mix the two environments together.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

The logs above show the thorn in our side: "Services.logins is undefined" - bug 1295122.

(In reply to Paul Nguyen, OMV from comment #5)
> Another note, :markh did suggest it was a bug 1295122 issue. I previously
> tried the tip to remove key3.db and the other files, and it comes right
> back. I don't know if it was expected to not be installed in a fresh
> profile. The default profile has a key3.db of 16,384 bytes. Current user
> profile has key3.db of same length.

The files are expected to come back - but it's very odd that removing key3.db, key4.db and logins.json, then restarting and having this problem persist.

About the best I can suggest now is to follow the instructions at https://wiki.mozilla.org/Firefox:Password_Manager_Debugging to try and see if we can determine what is going wrong in the login manager. Sadly though, I suspect this is going to end up as a dupe of bug 1295122.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mark Hammond [:markh] from comment #7)
> About the best I can suggest now is to follow the instructions at
> https://wiki.mozilla.org/Firefox:Password_Manager_Debugging to try and see
> if we can determine what is going wrong in the login manager. Sadly though,
> I suspect this is going to end up as a dupe of bug 1295122.

Actually, you already provided most of this information. From attachment 8964000 [details]:

> nsLoginManager: No alternate nsILoginManagerStorage registered nsLoginManager.js:122
> Login storage: Initialization failed: 
> Exception { name: "NS_ERROR_XPC_GS_RETURNED_FAILURE", message: "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]", result: 2153185302, filename: "jar:file:///C:/Program%20Files/Firefox%20Nightly/omni.ja!/components/crypto-SDR.js", lineNumber: 48, columnNumber: 0, data: null, ...

Which seems to still be pointing at code that should be resolved by deleting the files mentioned above. I'm not sure what else we can diagnose here without a full copy of the failing profile (which will certainly have alot of personal info, possibly including logins, so I fully understand that you will not want to share it).

So I'm going to clear the needinfo and mark this as a dupe, but please feel free to continue to comment here if you have any more information.

Comment 9

[Paul Nguyen, OMV]

yeah so I don't know what caused my previous config to break, but I did these two things:

nightly trials on April 3, 2018 with v 61.0a1 (2018-04-03) 64-bit
created fresh Windows local user account
in FF Nightly: enable signon logging, install about sync extension
connect to old sync account [e-mail]
seems to have no functional problems, although there is a large error log (attaching all for the session in a zip). 
relaunch.
seems to be fine.
set master password and tick "remember passwords".
relaunch.
works fine, prompts for password, fills form correctly.
checking error log folder, no further error logs. success log for each launch/sync.

Then I came back to my regular Windows User account. removed both my roaming and local Mozilla AppData folders entirely.
relaunched FF Dev Edition, looks to be stock, initializing a new profile.
Peeked inside the Roaming dev edition default profile: contains key4.db, no key3.db; cert9.db yes, cert8.db no; logins.json yes.
Relaunched.
Set Master Password. Synced fine.
Relaunched.
Seems to be running smoothly as I post this. So maybe just successive upgrades left some artifacts behind that interfered?

I'm happy with it now!

Comment 10

[Paul Nguyen, OMV]

Attachment: synclogs-fresh-user-nightly-20180403.zip

sync logs from clean slate test of nightly.