1448736 - Stop attaching Components to untrusted windows in SpecialPowers

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

SpecialPowers has this thing where it attaches Components to random content windows.  We should stop doing that.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop attaching Components to untrusted windows in SpecialPowers

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove the now-unused forcePrivilegedComponentsForScope API

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8962230 [details] [diff] [review]
part 1.  Stop attaching Components to untrusted windows in SpecialPowers

Review of attachment 8962230 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/specialpowers/content/specialpowersAPI.js
@@ -59,5 @@
>  }
>  
> -function getRawComponents(aWindow) {
> -  // If we're running in automation that supports enablePrivilege, then we also
> -  // provided access to the privileged Components.

Ugh.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Ugh.

I will see what I can do to nix enablePrivilege, or at lest its effects on Components, next... Tired of it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52a5c033931f
part 1.  Stop attaching Components to untrusted windows in SpecialPowers.  r=kmag
https://hg.mozilla.org/integration/mozilla-inbound/rev/8606ad41744a
part 2.  Remove the now-unused forcePrivilegedComponentsForScope API.  r=kmag

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/52a5c033931f
https://hg.mozilla.org/mozilla-central/rev/8606ad41744a