Closed Bug 1448755 Opened 3 years ago Closed 3 years ago

Use AssignLiteral and AssignASCII for short zero-terminated strings in networking

Categories

(Core :: Networking, enhancement, P1)

Product:
Core
Component:
Networking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1448755 - Use AssignLiteral and AssignASCII for short zero-terminated strings in networking. .
59 bytes, text/x-review-board-request
jduell.mcbugs
: review+
Details 
In bug 1402247, I'll be changing the signatures of the functions optimized for long strings not to take bare pointers, so these lines need *some* change anyway. It seems that AssignLiteral and AssignASCII make more sense.

Is the nsWifiAccessPoint case correct to begin with, though? Aren't SSIDs UTF-8?
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [necko-triaged]
Comment on attachment 8962249 [details]
Bug 1448755 - Use AssignLiteral and AssignASCII for short zero-terminated strings in networking. .

https://reviewboard.mozilla.org/r/231108/#review238248
Attachment #8962249 - Flags: review?(jduell.mcbugs) → review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27243339d0d6
Use AssignLiteral and AssignASCII for short zero-terminated strings in networking. r=jduell.
https://hg.mozilla.org/mozilla-central/rev/27243339d0d6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.