1448760 - Browser/web console do not remember window maximised state on Windows

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[erosman]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180324100127

Steps to reproduce:

Internal windows (history, Dev, console, etc) in 61.0a1 (2018-03-24) (64-bit) open up ALWAYS small and do no remember the maximised state.

This issue was not present before (60.0a1) and is new in 61.0a1 (2018-03-24) (64-bit) .

Comment 1

[erosman]

Not fixed yet on 61.0a1 (2018-03-26) (64-bit)

Comment 2

[Alice0775 White]

I can reproduce on Browser console

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

I tested 20180326220108 which is supposed to include fix of bug 1446264, and the original bug 1446264 is indeed fixed for the browser window.

However, it seems that web console and browser console somehow still don't remember the maximized state on Windows (while it works as expected on macOS).

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Re-purpose it to the browser console and web console.

Note that I cannot reproduce this issue on library (bookmarks and history) window. That should have been fixed in bug 1446264.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

I cannot reproduce this issue with 20180316100132 (which is the last nightly without bug 1439875) so supposedly this is also by that bug.

Comment 6

[erosman]

As of 61.0a1 (2018-03-26) (64-bit) Win, History, Bookmarks are fine.
Browser console (Ctrl + shift + J & F12) are still affected.

Comment 7

[Alice0775 White]

Scratchpad is also affected,

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

So the problem here is that, the window has "centerscreen" feature set, and thus we try to centering it after chrome loads, which pulls the window back from maximized state.

I guess there isn't really an approach we can exactly restore the old behavior (that the window is centered then maximized, which means when restore from the maximized state, the window would be center in the screen rather than restore the previous persisted position), but I guess skip centering the window in that case probably makes enough sense.

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1448760 - Don't try to center window after load when the size mode is not normal.

Review commit: https://reviewboard.mozilla.org/r/231568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231568/

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8962697 [details]
Bug 1448760 - Don't try to center window after load when the size mode is not normal.

https://reviewboard.mozilla.org/r/231568/#review237384

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2079554d753
Don't try to center window after load when the size mode is not normal. r=bz

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f2079554d753

Comment 13

[erosman]

Maximize issue appears fixed on 61.0a1 (2018-03-29) (64-bit) Win


New in 61.0a1 (2018-03-29) (64-bit) Win
Although ............. I don't seem to be able to clear the Browser console. I delete (Bin), it clears. After closing and reopening the console (Ctrl + Shift + J) the entries are still there.

errors from:
view-source:resource://devtools/client/inspector/markup/markup.js
etc
etc

Comment 14

[Xidorn Quan [:xidorn] UTC+11]

For anything different, please file new bug.

Comment 15

[erosman]

Filed under a new bug 1450186

The reason I mentioned it here was just in case, it had anything to do with the fix that was introduced in this bug.

Comment 16

[erosman]

Not sure if it is related or not.. seems related...

Debug: Developer Tools
The maximize is grey and can not resize the window manually
Also on lunch of extension debug.. the screens goes black first and then it shows. It seems like a black full size window is opened, then resized and content shown.

Comment 17

[erosman]

Update:
I was testing with 61.0a1 (2018-04-08) (64-bit) Win
comment 16 maximize issue is also fixed in the Debug: Developer Tools Console
Tested on 61.0a1 (2018-04-13) (64-bit) Win

The black screen flash is still there though.