Closed Bug 1448780 Opened 3 years ago Closed 3 years ago

Remove nsIEditor.numberOfUntoItems and nsIEditor.numberOfRedoItems

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

nsIEditor.numberOfUndoItems and nsIEditor.numberOfRedoItems are shortcut for its transaction managers nsITransactionManager.numberOfUndoItems and nsITransactionManager.numberOfRedoItems.  However, after fixing bug 1447924, those shortcut properties are not used by anybody:
https://searchfox.org/comm-central/search?q=numberOf(Undo%7CRedo)Items&case=false&regexp=true&path=
https://github.com/therealglazou/bluegriffon/search?utf8=%E2%9C%93&q=numberOfUndoItems&type=
https://github.com/therealglazou/bluegriffon/search?utf8=%E2%9C%93&q=numberOfRedoItems&type=

So, we can get rid of them after fixing bug 1447924.
# I don't know about addons for Thunderbird. It seems that we stopped managing addon source code with dxr.
Comment on attachment 8962364 [details]
Bug 1448780 - Get rid of nsIEditor.numberOfUndoItems and nsIEditor.numberOfRedoItems

https://reviewboard.mozilla.org/r/231224/#review236914
Attachment #8962364 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/fb567fcd8ea9
Get rid of nsIEditor.numberOfUndoItems and nsIEditor.numberOfRedoItems r=m_kato
https://hg.mozilla.org/mozilla-central/rev/fb567fcd8ea9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.