1448795 - nsMIMEInputStream must call OnInputStreamReady() with the correct nsIAsyncInputStream

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

This is is wrong:

    nsCOMPtr<nsIAsyncInputStream> asyncStream = do_QueryInterface(mStream);
    return asyncStream->AsyncWait(
        aCallback, aFlags, aRequestedCount, aEventTarget);

https://searchfox.org/mozilla-central/source/netwerk/base/nsMIMEInputStream.cpp#245-246

because the callback will receive the internal stream as argument and not the current nsIMIMEInputStream.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: mime.patch

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8962280 [details] [diff] [review]
mime.patch

Review of attachment 8962280 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I cut a corner at the time :(

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7429f5566dd9
nsMIMEInputStream must call OnInputStreamReady() with the correct nsIAsyncInputStream, r=asuth

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7429f5566dd9