Closed
Bug 1448810
Opened 6 years ago
Closed 6 years ago
Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils
Categories
(Firefox :: Bookmarks & History, enhancement, P3)
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
I'd like to clarify a bit the content files naming bookmarksPanel => bookmarksSidebar history-panel => historySidebar and there's no big point into having sidebarUtils, it can be merged into PUIU and uidensity into the respective sidebar init.
Assignee | ||
Updated•6 years ago
|
Whiteboard: [fxsearch]
Assignee | ||
Comment 1•6 years ago
|
||
I'd probably also merge organizer.css into places.css, since it only includes one rule (that may even not be necessary or wrong, it should probably be a max-width)
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8962539 [details] Bug 1448810 - Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils. https://reviewboard.mozilla.org/r/231344/#review237224 Much nicer and easier to understand.
Attachment #8962539 -
Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/84408e8f7f93 Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils. r=standard8
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/84408e8f7f93
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•