Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mak, Assigned: mak)

Tracking

(Blocks 1 bug)

55 Branch
Firefox 61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Assignee

Description

a year ago
I'd like to clarify a bit the content files naming
bookmarksPanel => bookmarksSidebar
history-panel => historySidebar
and there's no big point into having sidebarUtils, it can be merged into PUIU and uidensity into the respective sidebar init.
Assignee

Updated

a year ago
Whiteboard: [fxsearch]
Assignee

Comment 1

a year ago
I'd probably also merge organizer.css into places.css, since it only includes one rule (that may even not be necessary or wrong, it should probably be a max-width)
Comment on attachment 8962539 [details]
Bug 1448810 - Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils.

https://reviewboard.mozilla.org/r/231344/#review237224

Much nicer and easier to understand.
Attachment #8962539 - Flags: review?(standard8) → review+

Comment 4

a year ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/84408e8f7f93
Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils. r=standard8
Assignee

Updated

a year ago
Blocks: 1448788

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/84408e8f7f93
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.