Closed Bug 1448929 Opened 2 years ago Closed 2 years ago

Fix first sync check in `gSync.syncConfiguredAndLoading`

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: Lina, Assigned: Lina)

References

Details

Attachments

(1 file)

`lastSync` is now an async getter, which is tricky (and unnecessary, since prefs are synchronous) to use in `syncConfiguredAndLoading`...but it looks like we already have an `isFirstSync` getter that we can use without much work. \o/
Comment on attachment 8962403 [details]
Bug 1448929 - Fix first sync check in `gSync.syncConfiguredAndLoading`.

https://reviewboard.mozilla.org/r/231254/#review236666

LGTM!
Attachment #8962403 - Flags: review?(eoger) → review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a687dfe9f2de
Fix first sync check in `gSync.syncConfiguredAndLoading`. r=eoger
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4429679a013
Fix first sync check in `gSync.syncConfiguredAndLoading`. r=eoger
https://hg.mozilla.org/mozilla-central/rev/f4429679a013
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Flags: needinfo?(kit)
You need to log in before you can comment on or make changes to this bug.