1448929 - Fix first sync check in `gSync.syncConfiguredAndLoading`

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Lina Butler (ex-Mozilla)]

`lastSync` is now an async getter, which is tricky (and unnecessary, since prefs are synchronous) to use in `syncConfiguredAndLoading`...but it looks like we already have an `isFirstSync` getter that we can use without much work. \o/

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1448929 - Fix first sync check in `gSync.syncConfiguredAndLoading`.

Review commit: https://reviewboard.mozilla.org/r/231254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231254/

Comment 2

[Edouard Oger [:eoger]]

Comment on attachment 8962403 [details]
Bug 1448929 - Fix first sync check in `gSync.syncConfiguredAndLoading`.

https://reviewboard.mozilla.org/r/231254/#review236666

LGTM!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a687dfe9f2de
Fix first sync check in `gSync.syncConfiguredAndLoading`. r=eoger

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out changeset a687dfe9f2de (bug 1448929) for failing browser chrome tests on browser/base/content/test/urlbar/browser_page_action_menu.js on a CLOSED TREE

Log with the failure https://treeherder.mozilla.org/logviewer.html#?job_id=170370191&repo=autoland&lineNumber=2663
Backout revision https://hg.mozilla.org/integration/autoland/rev/84d7c46cdb88cb3202e4c7fb0406c673420db8c4

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a687dfe9f2de2bdc620dadfa7c3f8ab0a382fd5b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Comment 5

[Lina Butler (ex-Mozilla)]

Comment on attachment 8962403 [details]
Bug 1448929 - Fix first sync check in `gSync.syncConfiguredAndLoading`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231254/diff/1-2/

Comment 6

[Lina Butler (ex-Mozilla)]

Comment on attachment 8962403 [details]
Bug 1448929 - Fix first sync check in `gSync.syncConfiguredAndLoading`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231254/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4429679a013
Fix first sync check in `gSync.syncConfiguredAndLoading`. r=eoger

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f4429679a013